-
Notifications
You must be signed in to change notification settings - Fork 37.8k
Upgrade mac_alias to 2.0.7 #12417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mac_alias to 2.0.7 #12417
Conversation
Just for reference, here's the original PR for the mac_alias patch. |
2.0.7 has been released. |
The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system. Note that this PR won't be complete until a new version of mac_alias containing the path has been released, and the depends system is updated to reflect the new version.
0fc0bab
to
fc1bfcf
Compare
Added a commit upgrading mac_alias to 2.0.7 and did |
Tested ACK via Gitian Build: |
Looks good to me, @theuni might want to sign off on this because it's a depends change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK fc1bfcf. Thanks!
Thanks, everyone! @fanquake - Here you go. |
@droark You just have hidden files showing. That's normal. |
@theuni - Oh no, I understand the hidden folders. :) I just seemed to recall some issue/PR from awhile back where something similar was discussed, and how the macOS builds put the icons in odd places. I thought it had been resolved? I can't remember where I saw all this, though, and I could be wrong. Better safe than sorry! EDIT: Again, just to be clear, I was able to install the build without any problems, and I ran it for awhile on my Mac. This is purely a cosmetic issue, AFAIK. I wouldn't have even brought it up were it not for this being a depends upgrade. |
@droark what version of macOS are you using? |
@thijstriemstra - 10.13.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK fc1bfcf
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark) deee216 Delete mac_alias patch (Douglas Roark) Pull request description: The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system. Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version. Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark) deee216 Delete mac_alias patch (Douglas Roark) Pull request description: The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system. Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version. Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark) deee216 Delete mac_alias patch (Douglas Roark) Pull request description: The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system. Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version. Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark) deee216 Delete mac_alias patch (Douglas Roark) Pull request description: The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system. Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version. Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark) deee216 Delete mac_alias patch (Douglas Roark) Pull request description: The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system. Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version. Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark) deee216 Delete mac_alias patch (Douglas Roark) Pull request description: The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system. Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version. Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.
Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.