Skip to content

Conversation

droark
Copy link
Contributor

@droark droark commented Feb 12, 2018

The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.

@droark
Copy link
Contributor Author

droark commented Feb 12, 2018

Just for reference, here's the original PR for the mac_alias patch.

@maflcko maflcko added this to the Future milestone Feb 12, 2018
@thijstriemstra
Copy link

2.0.7 has been released.

The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

Note that this PR won't be complete until a new version of mac_alias containing the path has been released, and the depends system is updated to reflect the new version.
@droark droark force-pushed the master_del_mac_alias branch from 0fc0bab to fc1bfcf Compare February 14, 2018 01:05
@droark droark changed the title [WIP] Delete mac_alias patch Delete mac_alias patch Feb 14, 2018
@droark
Copy link
Contributor Author

droark commented Feb 14, 2018

Added a commit upgrading mac_alias to 2.0.7 and did make deploy on my Macbook Pro. The resultant DMG file allowed me to place Core in /Applications. Core runs fine. Background image of the DMG looks fine. A couple of the icons are in weird spots but this is apparently normal. Besides, as mentioned, the core functionality is present.

@jonasschnelli
Copy link
Contributor

Tested ACK via Gitian Build:
https://bitcoin.jonasschnelli.ch/build/499

@laanwj laanwj changed the title Delete mac_alias patch Upgrade mac_alias to 2.0.7 Feb 14, 2018
@laanwj
Copy link
Member

laanwj commented Feb 14, 2018

Looks good to me, @theuni might want to sign off on this because it's a depends change.

@fanquake
Copy link
Member

utACK fc1bfcf

@droark Could you post a screenshot of the out of place icons for reference?

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fc1bfcf. Thanks!

@droark
Copy link
Contributor Author

droark commented Feb 14, 2018

Thanks, everyone!

@fanquake - Here you go.

image

@theuni
Copy link
Member

theuni commented Feb 14, 2018

@droark You just have hidden files showing. That's normal.

@droark
Copy link
Contributor Author

droark commented Feb 14, 2018

@theuni - Oh no, I understand the hidden folders. :) I just seemed to recall some issue/PR from awhile back where something similar was discussed, and how the macOS builds put the icons in odd places. I thought it had been resolved? I can't remember where I saw all this, though, and I could be wrong. Better safe than sorry!

EDIT: Again, just to be clear, I was able to install the build without any problems, and I ran it for awhile on my Mac. This is purely a cosmetic issue, AFAIK. I wouldn't have even brought it up were it not for this being a depends upgrade.

@thijstriemstra
Copy link

@droark what version of macOS are you using?

@droark
Copy link
Contributor Author

droark commented Feb 14, 2018

@thijstriemstra - 10.13.3.

@fanquake fanquake removed this from the Future milestone Feb 15, 2018
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fc1bfcf

@laanwj laanwj merged commit fc1bfcf into bitcoin:master Feb 15, 2018
laanwj added a commit that referenced this pull request Feb 15, 2018
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark)
deee216 Delete mac_alias patch (Douglas Roark)

Pull request description:

  The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

  Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.

Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
@droark droark mentioned this pull request Feb 23, 2018
@droark droark deleted the master_del_mac_alias branch June 28, 2018 08:59
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 10, 2020
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark)
deee216 Delete mac_alias patch (Douglas Roark)

Pull request description:

  The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

  Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.

Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2020
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark)
deee216 Delete mac_alias patch (Douglas Roark)

Pull request description:

  The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

  Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.

Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2020
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark)
deee216 Delete mac_alias patch (Douglas Roark)

Pull request description:

  The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

  Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.

Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 24, 2021
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark)
deee216 Delete mac_alias patch (Douglas Roark)

Pull request description:

  The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

  Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.

Tree-SHA512: e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Jul 2, 2021
fc1bfcf Update mac_alias to 2.0.7 (Douglas Roark)
deee216 Delete mac_alias patch (Douglas Roark)

Pull request description:

  The patch Bitcoin Core has been maintaining for mac_alias was pulled 
by the mac_alias maintainer in commit 
4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove 
the patch from the depends system.

  Note that this PR won't be complete until a new version of mac_alias 
containing the patch has been released, and the depends system is 
updated to reflect the new version.

Tree-SHA512: 
e13f1b45c0a56e95645b1aff77036c8a24c29c3f18ea0d386fba8d6d0f5fd07c434afc09dcd644d46ca096d6a7a0d5097f1eca3be5b5a5475eb3d54407044fd9
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants