Require all tests to follow naming convention #12252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK 4de3d52e655902a07c85db84f0c6236302ef78a4 |
|
utACK 4de3d52. |
4de3d52 to
0b94082
Compare
|
Rebased |
|
Could you also fix the names in |
jnewbery
reviewed
Jan 26, 2018
test/functional/test_runner.py
Outdated
| print("Consider reducing EXPECTED_VIOLATION_COUNT from %d to %d" % (EXPECTED_VIOLATION_COUNT, len(bad_script_names))) | ||
| elif len(bad_script_names) > EXPECTED_VIOLATION_COUNT: | ||
| print("INFO: %d tests not meeting naming conventions (expected %d):" % (len(bad_script_names), EXPECTED_VIOLATION_COUNT)) | ||
| if len(bad_script_names) > 0: |
There was a problem hiding this comment.
more pythonic would be if bad_script_names: (https://www.python.org/dev/peps/pep-0008/#id51: "For sequences, (strings, lists, tuples), use the fact that empty sequences are false.")
test/functional/test_runner.py
Outdated
| print(" %s" % ("\n ".join(sorted(bad_script_names)))) | ||
| assert len(bad_script_names) <= EXPECTED_VIOLATION_COUNT + LEEWAY, "Too many tests not following naming convention! (%d found, expected: <= %d)" % (len(bad_script_names), EXPECTED_VIOLATION_COUNT) | ||
| assert len(bad_script_names) == 0, "Some tests are not following naming convention!" |
There was a problem hiding this comment.
This condition has already been tested. Just raise an assertion error:
raise AssertionError("Some tests are not following naming convention!")|
@MarcoFalke ah, sorry about that. #12292 should fix it. |
|
Are you planning on fixing up the nits? |
0b94082 to
125f4a4
Compare
|
Nits fixed as suggested, and rebased to make github happier |
|
utACK 125f4a4 |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 16, 2020
125f4a4 [tests] Require all tests to follow naming convention (Anthony Towns) Pull request description: Based on top of bitcoin#11774 Tree-SHA512: 1eb156b5a97b30c203b7b0ad3d2055b391ef825e2e57805c7745b5259a9b1caaa115768ec225452f12f354e550f83e071f9c6fee2c36698b4679191895aab8de
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 18, 2020
125f4a4 [tests] Require all tests to follow naming convention (Anthony Towns) Pull request description: Based on top of bitcoin#11774 Tree-SHA512: 1eb156b5a97b30c203b7b0ad3d2055b391ef825e2e57805c7745b5259a9b1caaa115768ec225452f12f354e550f83e071f9c6fee2c36698b4679191895aab8de
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #11774