Skip to content

Conversation

jeffrade
Copy link
Contributor

This PR is just a documentation update for someone (or myself) that looks into finishing up #7883 in the future.

Looked through #7883 and appears ryanofsky's PR setup the benchmarks, but there are FIXME comments to pull in data from test/ to get a larger data set (assuming reason why 7883 is still open).

@fanquake fanquake added the Docs label Jan 15, 2018
@bitcoin bitcoin deleted a comment from Bryantmeeder Jan 16, 2018
@bitcoin bitcoin deleted a comment from Bryantmeeder Jan 16, 2018
@maflcko
Copy link
Member

maflcko commented Jan 16, 2018

Could also mention that a help message can be printed by -?.

  -?
       Print this help message and exit

@jeffrade
Copy link
Contributor Author

@MarcoFalke Added a help section for the -? option. Small cleanup to match format of other md files in doc/. Direct link for visual.

@maflcko
Copy link
Member

maflcko commented Jan 16, 2018

ACK 7eaedea53214da7bcfc51b794b54de3663f02e03

@fanquake
Copy link
Member

utACK b21244e

@maflcko maflcko merged commit b21244e into bitcoin:master Jan 22, 2018
maflcko pushed a commit that referenced this pull request Jan 22, 2018
…ple output

b21244e Updating benchmarkmarking.md with an updated sample output and help options (Jeff Rade)

Pull request description:

  This PR is just a documentation update for someone (or myself) that looks into finishing up #7883 in the future.

  Looked through #7883 and appears [ryanofsky's PR](#8873) setup the benchmarks, but there are `FIXME` comments to pull in data from `test/` to get a larger data set (assuming reason why 7883 is still open).

Tree-SHA512: d758efc659c75f2b3ceb376f5a466c4234354077e4671ac3eb901c082c4e519ce5ff592cea4742711050b4ce56a1b65ef69433dd74e7db3eb11a8567d517d9e2
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 4, 2020
…ted sample output

b21244e Updating benchmarkmarking.md with an updated sample output and help options (Jeff Rade)

Pull request description:

  This PR is just a documentation update for someone (or myself) that looks into finishing up bitcoin#7883 in the future.

  Looked through bitcoin#7883 and appears [ryanofsky's PR](bitcoin#8873) setup the benchmarks, but there are `FIXME` comments to pull in data from `test/` to get a larger data set (assuming reason why 7883 is still open).

Tree-SHA512: d758efc659c75f2b3ceb376f5a466c4234354077e4671ac3eb901c082c4e519ce5ff592cea4742711050b4ce56a1b65ef69433dd74e7db3eb11a8567d517d9e2
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 5, 2020
…ted sample output

b21244e Updating benchmarkmarking.md with an updated sample output and help options (Jeff Rade)

Pull request description:

  This PR is just a documentation update for someone (or myself) that looks into finishing up bitcoin#7883 in the future.

  Looked through bitcoin#7883 and appears [ryanofsky's PR](bitcoin#8873) setup the benchmarks, but there are `FIXME` comments to pull in data from `test/` to get a larger data set (assuming reason why 7883 is still open).

Tree-SHA512: d758efc659c75f2b3ceb376f5a466c4234354077e4671ac3eb901c082c4e519ce5ff592cea4742711050b4ce56a1b65ef69433dd74e7db3eb11a8567d517d9e2
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 31, 2020
…sample output

Summary:
b21244e Updating benchmarkmarking.md with an updated sample output and help options (Jeff Rade)

Pull request description:

  This PR is just a documentation update for someone (or myself) that looks into finishing up #7883 in the future.

  Looked through #7883 and appears [ryanofsky's PR](bitcoin/bitcoin#8873) setup the benchmarks, but there are `FIXME` comments to pull in data from `test/` to get a larger data set (assuming reason why 7883 is still open).

---

Backport of Core [[bitcoin/bitcoin#12187 | PR12187]]

Test Plan: read it

Reviewers: #bitcoin_abc, PiRK

Reviewed By: PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8205
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants