[qa] Fix rare failure in p2p-segwit.py #12133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
reviewed
Jan 9, 2018
| tx.wit.vtxinwit.append(CTxInWitness()) | ||
| sign_P2PK_witness_input(witness_program, tx, index, SIGHASH_SINGLE|SIGHASH_ANYONECANPAY, i.nValue, key) | ||
| sign_P2PK_witness_input(witness_program, tx, index, SIGHASH_ALL|SIGHASH_ANYONECANPAY, i.nValue, key) |
There was a problem hiding this comment.
It felt wrong to use SIGHASH_SINGLE with an out-of-bounds index.
There was a problem hiding this comment.
ah, ok then comment could use an update a few lines up.
7fe5b20 to
d18c310
Compare
Avoid creating very small utxos that would violate an assumption in test_non_standard_witness.
d18c310 to
35c2b1f
Compare
|
Tested ACk 35c2b1f |
|
Thanks! utACK 35c2b1f. Created a similar fix last year, but somehow forgot to submit it. |
|
In |
|
Yes the PR comment makes it sound like it's a non-standard witness, rather than non-standard output. |
|
utACK 35c2b1f |
laanwj
added a commit
that referenced
this pull request
Jan 11, 2018
35c2b1f Fix rare failure in p2p-segwit.py (Suhas Daftuar) Pull request description: Avoid creating very small utxos that would violate an assumption in test_non_standard_witness. Fixes #11953 Tree-SHA512: 5fb7ae68f8731df819bab365923a84568b57227e4112f711fc2574767d15be83acd3e99d0d5bac94a42411a958b13a2119468babefed14efcfdda180004d4166
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating very small utxos that would violate an assumption in
test_non_standard_witness.
Fixes #11953