Skip to content

[depends] Fix Qt build with Xcode 9 #11995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2018
Merged

[depends] Fix Qt build with Xcode 9 #11995

merged 1 commit into from
Mar 5, 2018

Conversation

fanquake
Copy link
Member

Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

Fixes #11461
Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

@fanquake fanquake requested a review from theuni December 23, 2017 03:29
eugene-sy added a commit to meritlabs/merit that referenced this pull request Jan 11, 2018
@eugene-sy
fix building qt
ba3f865 
initially found in bitcoin repo bitcoin/bitcoin#11995
@eugene-sy eugene-sy mentioned this pull request Jan 11, 2018
Merged
@thijstriemstra thijstriemstra mentioned this pull request Jan 31, 2018
Closed
@fanquake fanquake mentioned this pull request Feb 15, 2018
Merged
@maflcko
Copy link
Member

maflcko commented Feb 16, 2018

We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

What is the status of this?

@fanquake fanquake mentioned this pull request Mar 3, 2018
Closed
@maflcko maflcko added this to the 0.16.1 milestone Mar 3, 2018
@maflcko
Copy link
Member

maflcko commented Mar 3, 2018

Looks like this is for backport?

@Sjors
Copy link
Member

Sjors commented Mar 5, 2018

Sadly fails: https://gist.github.com/Sjors/971ba439a5662b3992113339649631b4

@laanwj
Copy link
Member

laanwj commented Mar 5, 2018

Sadly fails: https://gist.github.com/Sjors/971ba439a5662b3992113339649631b4

Strange! That seems related to sse4 instructions support, not Qt. Do you have the same problem without this change?

theuni
theuni approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in-person, build failure looks unrelated. utACK after switching to a patch from upstream qt's git.

@fanquake fanquake force-pushed the macos-10-13-fix-depends-qt branch from c38960e to 2b1f794 Compare March 5, 2018 18:57
@fanquake
Copy link
Member Author

fanquake commented Mar 5, 2018

Updated to use an upstream patch. See https://bugreports.qt.io/browse/QTBUG-63401 & https://codereview.qt-project.org/gitweb?p=qt/qtbase.git;a=patch;h=0707260a4f8e64dfadf1df5f935e74cabb7c7d27.

@laanwj
Copy link
Member

laanwj commented Mar 5, 2018

utACK 2b1f794

@laanwj laanwj merged commit 2b1f794 into bitcoin:master Mar 5, 2018
laanwj added a commit that referenced this pull request Mar 5, 2018
@laanwj
Merge #11995: [depends] Fix Qt build with Xcode 9
9a75902 
2b1f794 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

  Fixes #11461
  Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

Tree-SHA512: b1aaa50580c5180bbae2d79f5618c145667edd824b66c20851c7346674a1700267d6df249ba559d781941def312f7867bc3950f673e9128ffd4beda2965ca639
@Sjors
Copy link
Member

Sjors commented Mar 5, 2018

I can't reproduce my issue with a fresh clone and it went away with make clean.

@fanquake fanquake mentioned this pull request Mar 7, 2018
Merged
fanquake added a commit to fanquake/bitcoin that referenced this pull request Mar 11, 2018
@fanquake
[Depends] Fix Qt build with Xcode 9.2
686cb86 
GitHub-Pull: bitcoin#11995
Rebased-From: 2b1f794
laanwj added a commit that referenced this pull request Mar 14, 2018
@laanwj
Merge #12636: backport: #11995 Fix Qt build with Xcode 9
845838c 
f3b8d85 devtools: Exclude patches from lint-whitespace GitHub-Pull: #12442 Rebased-From: fafbf7f (MarcoFalke)
686cb86 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  GitHub-Pull: #11995
  Rebased-From: 2b1f794

Tree-SHA512: 73d1c0a87fd135f3ad8bb737b97037ef047e582c41a7473833e82776957caf372fcd0caa764fc4eed792e9998e214ae829bad5535db6d589827085a74b0fa6f4
HashUnlimited pushed a commit to chaincoin/chaincoin that referenced this pull request Mar 16, 2018
@fanquake
[Depends] Fix Qt build with Xcode 9.2
9471ef4 
GitHub-Pull: bitcoin#11995
Rebased-From: 2b1f794
@fanquake fanquake deleted the macos-10-13-fix-depends-qt branch April 12, 2018 02:02
@fanquake
Copy link
Member Author

Removed "Needs Backport" as it was done in #12636.

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 26, 2018
@fanquake
[Depends] Fix Qt build with Xcode 9.2
9bb1a16 
GitHub-Pull: bitcoin#11995
Rebased-From: 2b1f794
@fanquake fanquake mentioned this pull request Apr 26, 2018
Merged
laanwj added a commit that referenced this pull request May 15, 2018
@laanwj
Merge #13093: [0.15] backport: depends qt patches
1618c63 
93b9a61 depends: Fix Qt build with XCode 9.3 (fanquake)
9bb1a16 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Backports #11995 and #12946 so that qt (and all depends) can still be built on the 0.15 branch.

Tree-SHA512: 671cce790b5f72c8edd04461d0bc3d300557c4df8c4e5d338561a972333edb34e2009f221d581fe3b2e61080cce0891588831c00c16d4ab852730f65856a3054
@sickpig sickpig mentioned this pull request Jun 5, 2018
Merged
XNotCopy pushed a commit to DigitalToaster/ReducedBitcoin that referenced this pull request Jun 21, 2018
@fanquake @XNotCopy
[Depends] Fix Qt build with Xcode 9.2
a31fc4d 
GitHub-Pull: bitcoin#11995
Rebased-From: 2b1f794
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Sep 25, 2018
@laanwj @UdjinM6
Merge bitcoin#13093: [0.15] backport: depends qt patches
b652a91 
93b9a61 depends: Fix Qt build with XCode 9.3 (fanquake)
9bb1a16 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Backports bitcoin#11995 and bitcoin#12946 so that qt (and all depends) can still be built on the 0.15 branch.

Tree-SHA512: 671cce790b5f72c8edd04461d0bc3d300557c4df8c4e5d338561a972333edb34e2009f221d581fe3b2e61080cce0891588831c00c16d4ab852730f65856a3054
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Sep 26, 2018
@fanquake @UdjinM6
[Depends] Fix Qt build with Xcode 9.2
a44d1d5 
GitHub-Pull: bitcoin#11995
Rebased-From: 2b1f794
codablock pushed a commit to codablock/dash that referenced this pull request Sep 28, 2018
@laanwj @codablock
Merge bitcoin#13093: [0.15] backport: depends qt patches
d817a38 
93b9a61 depends: Fix Qt build with XCode 9.3 (fanquake)
9bb1a16 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Backports bitcoin#11995 and bitcoin#12946 so that qt (and all depends) can still be built on the 0.15 branch.

Tree-SHA512: 671cce790b5f72c8edd04461d0bc3d300557c4df8c4e5d338561a972333edb34e2009f221d581fe3b2e61080cce0891588831c00c16d4ab852730f65856a3054
UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 30, 2018
@UdjinM6
Backport: Fix Qt build with XCode (for depends) (#2325)
8a1b513 
* [Depends] Fix Qt build with Xcode 9.2

GitHub-Pull: bitcoin#11995
Rebased-From: 2b1f794

* depends: Fix Qt build with XCode 9.3

GitHub-Pull: bitcoin#12946
Rebased-From: 5b4fc3e

* add newline
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 13, 2019
@UdjinM6 @CryptoCentric
Backport: Fix Qt build with XCode (for depends) (dashpay#2325)
2b0670d 
* [Depends] Fix Qt build with Xcode 9.2

GitHub-Pull: bitcoin#11995
Rebased-From: 2b1f794

* depends: Fix Qt build with XCode 9.3

GitHub-Pull: bitcoin#12946
Rebased-From: 5b4fc3e

* add newline
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 14, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11995: [depends] Fix Qt build with Xcode 9
ad7de75 
2b1f794 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

  Fixes bitcoin#11461
  Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

Tree-SHA512: b1aaa50580c5180bbae2d79f5618c145667edd824b66c20851c7346674a1700267d6df249ba559d781941def312f7867bc3950f673e9128ffd4beda2965ca639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 14, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11995: [depends] Fix Qt build with Xcode 9
668f045 
2b1f794 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

  Fixes bitcoin#11461
  Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

Tree-SHA512: b1aaa50580c5180bbae2d79f5618c145667edd824b66c20851c7346674a1700267d6df249ba559d781941def312f7867bc3950f673e9128ffd4beda2965ca639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 19, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11995: [depends] Fix Qt build with Xcode 9
b158839 
2b1f794 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

  Fixes bitcoin#11461
  Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

Tree-SHA512: b1aaa50580c5180bbae2d79f5618c145667edd824b66c20851c7346674a1700267d6df249ba559d781941def312f7867bc3950f673e9128ffd4beda2965ca639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 28, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11995: [depends] Fix Qt build with Xcode 9
d8520ca 
2b1f794 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

  Fixes bitcoin#11461
  Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

Tree-SHA512: b1aaa50580c5180bbae2d79f5618c145667edd824b66c20851c7346674a1700267d6df249ba559d781941def312f7867bc3950f673e9128ffd4beda2965ca639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 29, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11995: [depends] Fix Qt build with Xcode 9
b248a3f 
2b1f794 [Depends] Fix Qt build with Xcode 9.2 (fanquake)

Pull request description:

  Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We'll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

  Fixes bitcoin#11461
  Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

Tree-SHA512: b1aaa50580c5180bbae2d79f5618c145667edd824b66c20851c7346674a1700267d6df249ba559d781941def312f7867bc3950f673e9128ffd4beda2965ca639
UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Mar 30, 2020
@UdjinM6
Revert "Merge bitcoin#11995: [depends] Fix Qt build with Xcode 9"
fbf96a0 
This reverts commit b248a3f.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@theuni theuni theuni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build system macOS
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.

[depends] Qt build broken with latest Xcode
5 participants
@fanquake @maflcko @Sjors @laanwj @theuni