Skip to content

Conversation

meshcollider
Copy link
Contributor

@meshcollider meshcollider commented Sep 24, 2017

The gitian-build.sh script crashes with an error when I tried to use it, @kallewoof also had this same issue:

lxcbr0: ERROR while getting interface flags: No such device
SIOCSIFADDR: No such device
lxcbr0: ERROR while getting interface flags: No such device

And then:

lxc-execute: failed to find gateway addresses
lxc-execute: failed to spawn 'gitian'
./bin/gbuild:21:in `system!': failed to run make-clean-vm --suite trusty --arch amd64 (RuntimeError)

I believe it's because of the two lines which this PR removes, I tested it and seems to work as expected now. These lines are unique to this script and aren't mentioned in gitian-building.md or release-process.md. We discussed it on IRC, @achow101 agrees removing these lines would probably fix it: https://botbot.me/freenode/bitcoin-core-dev/2017-09-19/?msg=91299782&page=2

Has anyone successfully used this script as-is? Or does everyone else manually run the builds/write their own script like I have up til this point?

@achow101
Copy link
Member

achow101 commented Sep 24, 2017

Has anyone successfully used this script as-is? Or does everyone else manually run the builds/write their own script like I have up til this point?

Yes, it's my script and there was a reason for those two lines there (it fixed some problems for me in the past). Removing those two lines doesn't effect my setup now (for some reason) so it should be fine to remove them.

Edit: Actually removing them does break my setup now. Normally I use kvm anyways so I don't notice it, but without those lines, things are broken.

@meshcollider
Copy link
Contributor Author

meshcollider commented Sep 24, 2017

Hmm how did you set up that bridge? It's not mentioned in any docs so maybe it's them that need amending not this. Do you also have a br0 bridge (the one configured here: https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#setting-up-debian-for-gitian-building)? Or just lxcbr0?

@achow101
Copy link
Member

I don't remember how that was all actually setup; I did it years ago. I believe it may be the same thing as the br0 setup in the gitian building guide but my setup probably had some weirdness to it or had br0 already taken by something else. I believe that it may have also been that lxc was defaulting to using lxcbr0 for me instead of br0. I'm not sure.

@meshcollider
Copy link
Contributor Author

I think it makes more sense to have the script consistent with the VM set up in the docs, so it'd be good if at least one other person (ping @kallewoof ?) could confirm this fixes it like it does for me

@kallewoof
Copy link
Contributor

Sorry for lack of response. I actually gave up trying to get this all to work as there are a few too many assumptions that I can't guess correctly. I believe the fix you suggest enables the --setup call. Even without this change I am able to run the --build variant, but I have no idea if the results are actually valid as I haven't verified or signed anything yet. Sorry, I will try to get back on this. For now, weak ACK from me.

@maflcko
Copy link
Member

maflcko commented Sep 29, 2017

Concept ACK. I don't think we should include workarounds that only work on a single dev's machine.

@maflcko
Copy link
Member

maflcko commented Sep 30, 2017

It's not mentioned in any docs

Indeed, this is causing confusion: bitcoin-core/docs#3

@maflcko maflcko merged commit 8849130 into bitcoin:master Sep 30, 2017
maflcko pushed a commit that referenced this pull request Sep 30, 2017
8849130 Remove lxcbr0 lines from gitian-build.sh (MeshCollider)

Pull request description:

  The `gitian-build.sh` script crashes with an error when I tried to use it, @kallewoof also had this same issue:

  	lxcbr0: ERROR while getting interface flags: No such device
  	SIOCSIFADDR: No such device
  	lxcbr0: ERROR while getting interface flags: No such device

  And then:

  	lxc-execute: failed to find gateway addresses
  	lxc-execute: failed to spawn 'gitian'
  	./bin/gbuild:21:in `system!': failed to run make-clean-vm --suite trusty --arch amd64 (RuntimeError)

  I believe it's because of the two lines which this PR removes, I tested it and seems to work as expected now. These lines are unique to this script and aren't mentioned in `gitian-building.md` or `release-process.md`. We discussed it on IRC, @achow101 agrees removing these lines would probably fix it: https://botbot.me/freenode/bitcoin-core-dev/2017-09-19/?msg=91299782&page=2

  Has anyone successfully used this script as-is? Or does everyone else manually run the builds/write their own script like I have up til this point?

Tree-SHA512: 0cffd3df307ad107fb1d4bae45094fc5002b56c2fe64f03642d968659fdc62f586ba249dbc540b69058b276f2456962e5bc4d665cab21ef1f561735eb78afcc2
@meshcollider meshcollider deleted the 201709_gitian_script_fix branch September 30, 2017 08:15
@Sjors
Copy link
Member

Sjors commented Nov 4, 2017

Can this be added to v0.15.1?

@achow101
Copy link
Member

achow101 commented Nov 4, 2017

@Sjors You can and should just copy the script out of the folder where you have the bitcoin source and use it from outside of that. There you can make any modifications that you want to it without said modifications being effected by the git tree changing.

ckeyer pushed a commit to ckeyer/bitcoin that referenced this pull request Dec 2, 2017
- Cannot finish Initial Block Download stage
- Refuse to connect to non-default ports in 50 tries.

Temporarily disable mainnet as it's not ready yet.

Fix the basic info of testnet fork block.

Use the same network magic for regtest mode.

Adjusted difficulty change based on BTCGPU/BTCGPU#78

Update README.md

Allow to connect to Bitcoin network with -bootstrap flag.

Fix wrong GetDifficulty calculation.

Minor fixes.

- Allow bitcoin magic whe bootstraping
- Temporarily disable premine conbase check

Fixed difficulty adjustment

Change magic of signed message

Flag to disable IBD after fork.

fix typo

A few edits to paths and names

force new tx with FORKID to use bip143 transaction digest algorithm

Fix p2p-segwit & p2pfullblcoktest

add explicit amount in all regtests, all regtests are passed

Corrected the PoW adjustment parameters.

Changed the pow averaging window to 30 from 20C
Changed network magic.

Add getblocksubsidy to rpc.

Make Zcash compatible.

Update command help.

Rebranded core wallet

Allow to connect to Bitocin mainnet in `-bootstrap` mode.

Fix CScript string decoding issue

Test CLTV-multi-sig wallet for Bitcoin Gold.

Tested:
./test/functional/btg-timelock.py

Add CLTV-multisig whitelist for premine.

Tested:
./src/test/test_bitcoin --run_test=btg_tests

Move cltv_multisig_data.h out of generated data directory.

Fix nits in regtest btg-timelock.py.

Enforce CLTV-multi-sig for premine

Enable mainnet connection.

Change default windows install path.

Tested:
make deploy

Add more dnsseed.

Fix linearize-data.py for BTG block format.

Update README.md

fix typo

Rename configuration file

Change 'Bitcoin server' to 'BitcoinGold' server

Update Readme.md

Fix wrong word

Fixed gitian build

Clean gitian PGP keys from Core

Add gitian PGP key: wjcloud

Adding public key for gitian build

Fix naming of build artifacts to bitcoin-gold-...

Build artifacts (tarball produced by
`make dist` and the packages produced by gitian builds
are now named bitcoin-gold-XXXXXXXXXXXXXX
where the XXXXXXXXX part includes the version number
and followed by more specifics such as platform / architecture
in case of gitian build products.

Fix inconsistencies and grammar in various files & remove old md guide

Remove lxcbr0 lines from gitian-build.sh

Because it errors when building with lxc bitcoin#11391

Rollback some changes

Updated website url.

Add pgp key for h4x3rotab
ckeyer pushed a commit to ckeyer/bitcoin that referenced this pull request Dec 2, 2017
Initial commit

Rename README.md to CORE-README.md

Remove LICENSE file

README

Will be continupusly creating content

PoW retargeting change for BTG hard fork permine proid.

- Fork from block #487427.
- Premine 16000 blocks.
- Minimal difficulty for the premining peroid.

PoW: Add dependency libsdoium for equihash.

Tested:
make (macOS 10.12.5, Xcode 8.3.3)

PoW: Import equihash.

Tested:
make

Add Equihash parameters N & K to chainparams.

Hardfork: Introduce new protocol version & versionbits.

Protocol version: 70016 (BTG_HARD_FORK_VERSION)
Version bits: 0x60000000

Hardfork: New fields in block header

- Add two new fields: nHeight, nSolution (for Equihash)
- Calculate block hash in new block format after the hard fork.
- Serialize block in legacy format when talking to Bitcoin node.

Tested:
unittest

Link sodium in qt wallet.

Tested:
./autogen.sh && make

PoW: Add Equihash validation functions.

- Initialize sodium on startup
- Add Equihash validation logic
- Fix missing htole32 problem in mingw build.

Backward compatible block serialization.

- Serialize in different formats based on the net protocol version.
- Remove the version bit 0x40000000.
- Support legacy block format for RPCs: getblock, getblockheader, getblocktemplate, submitblock.
- Temporarily disable SEND_CMPT.

Tested:
unit tests

Fix broken regression tests.

Intended broken testes:
- p2p-compactblocks.py
- rest.py

Tested:
reg tests.

Fix typo.

Block header compatible with Zcash.

- Add fields to block header for Zcash compatibility
- Extend the nonce from `uint32_t` to `uint256`
- Add 'nonceUint32' for backward compatibility:
  - RPC: 'getblockheader', 'getblock'
  - Rest: '/rest/headers', '/rest/block'

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py
(all passed except intended failures: p2p-compactblocks.py, rest.py)

Fix unaligned block header problem.

Also add a test to ensure Zcash compability.

Tested:
./src/test/test_bitcoin --run_test=btg_tests

Add the sanity test for libsodium.

Tested:
./src/test/test_bitcoin --run_test=sanity_tests

Fix linux build issue.

misc: Fix linux build and reduce verbose logging

Add unittests for Equihash PoW.

Tested:
./src/test/test_bitcoin --run_test=equihash_tests

Validate Equihash solution.

RPC for mining and basic tests.

- RPC
  - generate
  - generatetoaddress
  - getblocktemplate
- Add regtest `btg-hardfork.py`

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py

Fix rest api and skip p2p-compactblocks.py

Updated Configure.ac

Changed branding.

Add Travis-CI build status image in README.md

Changing client name

Changed from "Satoshi" to "Bitcoin Gold"

Slight edits

Small edit

Small edits

Misc

name edits

Misc

--

Misc

--

Misc, name

Name changing

Misc

Added the right project name.

Change name to Bitcoin Gold

---

Fix name

More name edits

Name edit.

name edit

BTC -> BTG

Update amount.h

Change unti from BTC to BTG

Switch name

Not sure if I should change the strings to such as "Bitcoins" to "Bitcoin Golds"

Update bitcoinunits.h

Update coincontroldialog.cpp

Update overviewpage.ui

Update sendcoinsdialog.ui

Update guiutil.cpp

Update optionsmodel.cpp

Update overviewpage.cpp

Update sendcoinsentry.cpp

Update paymentrequestdata.h

Update paymentservertests.cpp

Update mining.cpp

Update mining.cpp

Update compress_tests.cpp

Update miner_tests.cpp

Update rpc_tests.cpp

Change the description

Update README.md

Change the name from "bitcoin" to "bgold"

Change bgold to bgoldd

Be more specific about the fork date

Update readme with exact block height

Link to our own website for security issues, until we have a dedicated URL

Better than linking to Bitcoin core, we submit bugs to them, our users submit bugs to us. Zcash has a dedicated `doc/security.md` which Hush inherited and that I maintain for Hush.

Link to our website.

Added our site url, now that our site is finished.

Implement difficulty adjustment each block
Changed ports to 8338 for mainnet and 18338 for testnet

Changed name of daemon and cli to bgoldd and bgold-cli

Moved directory to BitcoinGold / .bitcoingold

Fallback to previous difficulty change logic if BTG block is created.

fixed block for the slip

Precalculated the change of the diff adjust algorithm and corrected the values. Minor other changes.

Set testnet exact fork time. Minor changes.

Removed unnecessary assertion line in the regtest config

Fixed test execution

Update README.md

Skip p2p-compactblocks.py in TravisCI test.

Change default BITCOIND to bgoldd.

Fix bad testnet consensus params.

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py

Fix build errors.

- Link boost_system for Equihash library.
- Remove unnecessary LIBEQUIHASH_LIBS from libbitcoinconsensus.la.

Tested:
./autogen.sh && make

Support "legacy" param in RPCs

Change mainnet address version.

- Prefix 38 (G) for P2PKH.
- Prefix 90 (d) for P2SH.

Change P2SH prefix to "A" (23).

Also fixed unit tests.

Add `-convertaddress` in bgold-cli.

Usage: `bgold-cli -testnet=false -convertaddress=<address>`

Fix broken tests for new address format.

Update README.md

update to release 1.0.15

updatae to new relase needed because compiler crashed on ubuntu
14.04 & 16.04 with older versions installed.

solves bitcoin#43
see also bitcoin#53

update source for libsodium to 1.0.15

compiling fails with older version than 1.0.13 and libsodium needs #
to be compiled from the scratch for ubuntu 14.04 and 16.04

solves bitcoin#43
see also bitcoin#53

Update README.md

Fix various places referring to the old BTC port number

Update a few places with our new 8338 port

updated for OSX builders

Updated build tutorial for OSX contributors  (missing dependencies) .

Update README.md

Add foundersReward

Prevent transaction in premineWindow and create premineAddressWhitelist.

remove -lboost_system

Update build-unix.md

add libsodium-dev missing ...

Disable LogPrint in target libconsensus_la.

Disable bitcoin libs to make TravisCI happy.

Tested:
./autogen.sh && ./configure && make

Change powLimit for Equihash.

The default powLimit is too difficult for Equihash. We relex it to the same as Zcash.

Other changes:
- Fix edge case of powLimit.
- Revert `pow_tests.cpp` to bitcoin version.

Mark client version as not a realse version.

Change testnet fork height to 1210320.

Misc fixes.

- Change the premine whitelist placeholder to BTG address format.
- Reduce testnet premine window to 200 blocks.

Removed main seeds

Added libsodium

Fix bad testnet consensus params.

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py

WIP

WIP

Changed PCH message start

Changed bitcoin node port

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

Changed label

Removed main seeds

WIP

WIP

Changed PCH message start

Changed bitcoin node port

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

After rebase

Changed minimum difficulty.

Fixes not working magic

Removed previous seeds

Removed main seeds

Update README.md

WIP

WIP

Changed PCH message start

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

Removed main seeds

WIP

WIP

Changed PCH message start

Changed bitcoin node port

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

Changed minimum difficulty.

Fixes not working magic

Update pow.cpp

Update pow.cpp

Update README.md

Removed wrong indent

Removed empty line

Reverted pow.cpp

Removed empty line

Removed commented DNS seeds

Add SIGHASH_FORKID, a 2-way replay protection

Require FORKID mechanism to be enabled by default, except for some
special cases like legacy tests and blocks under BTG HF height

Add fork id to legacy tests and add replay attacks

All unit tests are passed

Add fork id to regtests

Add -bootstrap for syncing block history

Fix bootstrap related issues.

- Cannot finish Initial Block Download stage
- Refuse to connect to non-default ports in 50 tries.

Temporarily disable mainnet as it's not ready yet.

Fix the basic info of testnet fork block.

Use the same network magic for regtest mode.

Adjusted difficulty change based on BTCGPU/BTCGPU#78

Update README.md

Allow to connect to Bitcoin network with -bootstrap flag.

Fix wrong GetDifficulty calculation.

Minor fixes.

- Allow bitcoin magic whe bootstraping
- Temporarily disable premine conbase check

Fixed difficulty adjustment

Change magic of signed message

Flag to disable IBD after fork.

fix typo

A few edits to paths and names

force new tx with FORKID to use bip143 transaction digest algorithm

Fix p2p-segwit & p2pfullblcoktest

add explicit amount in all regtests, all regtests are passed

Corrected the PoW adjustment parameters.

Changed the pow averaging window to 30 from 20C
Changed network magic.

Add getblocksubsidy to rpc.

Make Zcash compatible.

Update command help.

Rebranded core wallet

Allow to connect to Bitocin mainnet in `-bootstrap` mode.

Fix CScript string decoding issue

Test CLTV-multi-sig wallet for Bitcoin Gold.

Tested:
./test/functional/btg-timelock.py

Add CLTV-multisig whitelist for premine.

Tested:
./src/test/test_bitcoin --run_test=btg_tests

Move cltv_multisig_data.h out of generated data directory.

Fix nits in regtest btg-timelock.py.

Enforce CLTV-multi-sig for premine

Enable mainnet connection.

Change default windows install path.

Tested:
make deploy

Add more dnsseed.

Fix linearize-data.py for BTG block format.

Update README.md

fix typo

Rename configuration file

Change 'Bitcoin server' to 'BitcoinGold' server

Update Readme.md

Fix wrong word

Fixed gitian build

Clean gitian PGP keys from Core

Add gitian PGP key: wjcloud

Adding public key for gitian build

Fix naming of build artifacts to bitcoin-gold-...

Build artifacts (tarball produced by
`make dist` and the packages produced by gitian builds
are now named bitcoin-gold-XXXXXXXXXXXXXX
where the XXXXXXXXX part includes the version number
and followed by more specifics such as platform / architecture
in case of gitian build products.

Fix inconsistencies and grammar in various files & remove old md guide

Remove lxcbr0 lines from gitian-build.sh

Because it errors when building with lxc bitcoin#11391

Rollback some changes

Updated website url.

Add pgp key for h4x3rotab
ckeyer pushed a commit to ckeyer/bitcoin that referenced this pull request Dec 2, 2017
Rename README.md to CORE-README.md

Remove LICENSE file

README

Will be continupusly creating content

PoW retargeting change for BTG hard fork permine proid.

- Fork from block #487427.
- Premine 16000 blocks.
- Minimal difficulty for the premining peroid.

PoW: Add dependency libsdoium for equihash.

Tested:
make (macOS 10.12.5, Xcode 8.3.3)

PoW: Import equihash.

Tested:
make

Add Equihash parameters N & K to chainparams.

Hardfork: Introduce new protocol version & versionbits.

Protocol version: 70016 (BTG_HARD_FORK_VERSION)
Version bits: 0x60000000

Hardfork: New fields in block header

- Add two new fields: nHeight, nSolution (for Equihash)
- Calculate block hash in new block format after the hard fork.
- Serialize block in legacy format when talking to Bitcoin node.

Tested:
unittest

Link sodium in qt wallet.

Tested:
./autogen.sh && make

PoW: Add Equihash validation functions.

- Initialize sodium on startup
- Add Equihash validation logic
- Fix missing htole32 problem in mingw build.

Backward compatible block serialization.

- Serialize in different formats based on the net protocol version.
- Remove the version bit 0x40000000.
- Support legacy block format for RPCs: getblock, getblockheader, getblocktemplate, submitblock.
- Temporarily disable SEND_CMPT.

Tested:
unit tests

Fix broken regression tests.

Intended broken testes:
- p2p-compactblocks.py
- rest.py

Tested:
reg tests.

Fix typo.

Block header compatible with Zcash.

- Add fields to block header for Zcash compatibility
- Extend the nonce from `uint32_t` to `uint256`
- Add 'nonceUint32' for backward compatibility:
  - RPC: 'getblockheader', 'getblock'
  - Rest: '/rest/headers', '/rest/block'

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py
(all passed except intended failures: p2p-compactblocks.py, rest.py)

Fix unaligned block header problem.

Also add a test to ensure Zcash compability.

Tested:
./src/test/test_bitcoin --run_test=btg_tests

Add the sanity test for libsodium.

Tested:
./src/test/test_bitcoin --run_test=sanity_tests

Fix linux build issue.

misc: Fix linux build and reduce verbose logging

Add unittests for Equihash PoW.

Tested:
./src/test/test_bitcoin --run_test=equihash_tests

Validate Equihash solution.

RPC for mining and basic tests.

- RPC
  - generate
  - generatetoaddress
  - getblocktemplate
- Add regtest `btg-hardfork.py`

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py

Fix rest api and skip p2p-compactblocks.py

Updated Configure.ac

Changed branding.

Add Travis-CI build status image in README.md

Changing client name

Changed from "Satoshi" to "Bitcoin Gold"

Slight edits

Small edit

Small edits

Misc

name edits

Misc

--

Misc

--

Misc, name

Name changing

Misc

Added the right project name.

Change name to Bitcoin Gold

---

Fix name

More name edits

Name edit.

name edit

BTC -> BTG

Update amount.h

Change unti from BTC to BTG

Switch name

Not sure if I should change the strings to such as "Bitcoins" to "Bitcoin Golds"

Update bitcoinunits.h

Update coincontroldialog.cpp

Update overviewpage.ui

Update sendcoinsdialog.ui

Update guiutil.cpp

Update optionsmodel.cpp

Update overviewpage.cpp

Update sendcoinsentry.cpp

Update paymentrequestdata.h

Update paymentservertests.cpp

Update mining.cpp

Update mining.cpp

Update compress_tests.cpp

Update miner_tests.cpp

Update rpc_tests.cpp

Change the description

Update README.md

Change the name from "bitcoin" to "bgold"

Change bgold to bgoldd

Be more specific about the fork date

Update readme with exact block height

Link to our own website for security issues, until we have a dedicated URL

Better than linking to Bitcoin core, we submit bugs to them, our users submit bugs to us. Zcash has a dedicated `doc/security.md` which Hush inherited and that I maintain for Hush.

Link to our website.

Added our site url, now that our site is finished.

Implement difficulty adjustment each block
Changed ports to 8338 for mainnet and 18338 for testnet

Changed name of daemon and cli to bgoldd and bgold-cli

Moved directory to BitcoinGold / .bitcoingold

Fallback to previous difficulty change logic if BTG block is created.

fixed block for the slip

Precalculated the change of the diff adjust algorithm and corrected the values. Minor other changes.

Set testnet exact fork time. Minor changes.

Removed unnecessary assertion line in the regtest config

Fixed test execution

Update README.md

Skip p2p-compactblocks.py in TravisCI test.

Change default BITCOIND to bgoldd.

Fix bad testnet consensus params.

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py

Fix build errors.

- Link boost_system for Equihash library.
- Remove unnecessary LIBEQUIHASH_LIBS from libbitcoinconsensus.la.

Tested:
./autogen.sh && make

Support "legacy" param in RPCs

Change mainnet address version.

- Prefix 38 (G) for P2PKH.
- Prefix 90 (d) for P2SH.

Change P2SH prefix to "A" (23).

Also fixed unit tests.

Add `-convertaddress` in bgold-cli.

Usage: `bgold-cli -testnet=false -convertaddress=<address>`

Fix broken tests for new address format.

Update README.md

update to release 1.0.15

updatae to new relase needed because compiler crashed on ubuntu
14.04 & 16.04 with older versions installed.

solves bitcoin#43
see also bitcoin#53

update source for libsodium to 1.0.15

compiling fails with older version than 1.0.13 and libsodium needs #
to be compiled from the scratch for ubuntu 14.04 and 16.04

solves bitcoin#43
see also bitcoin#53

Update README.md

Fix various places referring to the old BTC port number

Update a few places with our new 8338 port

updated for OSX builders

Updated build tutorial for OSX contributors  (missing dependencies) .

Update README.md

Add foundersReward

Prevent transaction in premineWindow and create premineAddressWhitelist.

remove -lboost_system

Update build-unix.md

add libsodium-dev missing ...

Disable LogPrint in target libconsensus_la.

Disable bitcoin libs to make TravisCI happy.

Tested:
./autogen.sh && ./configure && make

Change powLimit for Equihash.

The default powLimit is too difficult for Equihash. We relex it to the same as Zcash.

Other changes:
- Fix edge case of powLimit.
- Revert `pow_tests.cpp` to bitcoin version.

Mark client version as not a realse version.

Change testnet fork height to 1210320.

Misc fixes.

- Change the premine whitelist placeholder to BTG address format.
- Reduce testnet premine window to 200 blocks.

Removed main seeds

Added libsodium

Fix bad testnet consensus params.

Tested:
./src/test/test_bitcoin
./test/functional/test_runner.py

WIP

WIP

Changed PCH message start

Changed bitcoin node port

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

Changed label

Removed main seeds

WIP

WIP

Changed PCH message start

Changed bitcoin node port

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

After rebase

Changed minimum difficulty.

Fixes not working magic

Removed previous seeds

Removed main seeds

Update README.md

WIP

WIP

Changed PCH message start

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

Removed main seeds

WIP

WIP

Changed PCH message start

Changed bitcoin node port

Legacy logic for Magic

Minor changes on the Magic

Changed incorrect Magic for testnet
Reversed flags

Changed minimum difficulty.

Fixes not working magic

Update pow.cpp

Update pow.cpp

Update README.md

Removed wrong indent

Removed empty line

Reverted pow.cpp

Removed empty line

Removed commented DNS seeds

Add SIGHASH_FORKID, a 2-way replay protection

Require FORKID mechanism to be enabled by default, except for some
special cases like legacy tests and blocks under BTG HF height

Add fork id to legacy tests and add replay attacks

All unit tests are passed

Add fork id to regtests

Add -bootstrap for syncing block history

Fix bootstrap related issues.

- Cannot finish Initial Block Download stage
- Refuse to connect to non-default ports in 50 tries.

Temporarily disable mainnet as it's not ready yet.

Fix the basic info of testnet fork block.

Use the same network magic for regtest mode.

Adjusted difficulty change based on BTCGPU/BTCGPU#78

Update README.md

Allow to connect to Bitcoin network with -bootstrap flag.

Fix wrong GetDifficulty calculation.

Minor fixes.

- Allow bitcoin magic whe bootstraping
- Temporarily disable premine conbase check

Fixed difficulty adjustment

Change magic of signed message

Flag to disable IBD after fork.

fix typo

A few edits to paths and names

force new tx with FORKID to use bip143 transaction digest algorithm

Fix p2p-segwit & p2pfullblcoktest

add explicit amount in all regtests, all regtests are passed

Corrected the PoW adjustment parameters.

Changed the pow averaging window to 30 from 20C
Changed network magic.

Add getblocksubsidy to rpc.

Make Zcash compatible.

Update command help.

Rebranded core wallet

Allow to connect to Bitocin mainnet in `-bootstrap` mode.

Fix CScript string decoding issue

Test CLTV-multi-sig wallet for Bitcoin Gold.

Tested:
./test/functional/btg-timelock.py

Add CLTV-multisig whitelist for premine.

Tested:
./src/test/test_bitcoin --run_test=btg_tests

Move cltv_multisig_data.h out of generated data directory.

Fix nits in regtest btg-timelock.py.

Enforce CLTV-multi-sig for premine

Enable mainnet connection.

Change default windows install path.

Tested:
make deploy

Add more dnsseed.

Fix linearize-data.py for BTG block format.

Update README.md

fix typo

Rename configuration file

Change 'Bitcoin server' to 'BitcoinGold' server

Update Readme.md

Fix wrong word

Fixed gitian build

Clean gitian PGP keys from Core

Add gitian PGP key: wjcloud

Adding public key for gitian build

Fix naming of build artifacts to bitcoin-gold-...

Build artifacts (tarball produced by
`make dist` and the packages produced by gitian builds
are now named bitcoin-gold-XXXXXXXXXXXXXX
where the XXXXXXXXX part includes the version number
and followed by more specifics such as platform / architecture
in case of gitian build products.

Fix inconsistencies and grammar in various files & remove old md guide

Remove lxcbr0 lines from gitian-build.sh

Because it errors when building with lxc bitcoin#11391

Rollback some changes

Updated website url.

Add pgp key for h4x3rotab

rm md

up
h4x3rotab pushed a commit to BTCGPU/BTCGPU that referenced this pull request Dec 20, 2017
Because it errors when building with lxc bitcoin/bitcoin#11391
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants