Fix crash on shutdown with invalid wallet #11326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK 77939f2 |
|
utACK 77939f2 |
maflcko
pushed a commit
that referenced
this pull request
Sep 14, 2017
77939f2 Fix uninitialized g_connman crash in Shutdown() (MeshCollider) Pull request description: Fixes #11312 As @dooglus pointed out, `g_connman` is uninitialized when an invalid wallet path is passed on start up, but then dereferenced in `Shutdown()`, so this tiny PR just fixes that. Tree-SHA512: 2557133422a6e393017081450a7e6c100fe7d9ce36e628e5f5f479bc07617a7bd9a9ad4d44c0d8abadf2e3eb62a11ce9743abc27b4ae8c20f709e72df4f25a7f
|
Needs backport? |
|
No, no backport needed, since #10756 is only in master. |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 2, 2017
Github-Pull: bitcoin#11326 Rebased-From: 77939f2
Merged
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 26, 2019
77939f2 Fix uninitialized g_connman crash in Shutdown() (MeshCollider) Pull request description: Fixes bitcoin#11312 As @dooglus pointed out, `g_connman` is uninitialized when an invalid wallet path is passed on start up, but then dereferenced in `Shutdown()`, so this tiny PR just fixes that. Tree-SHA512: 2557133422a6e393017081450a7e6c100fe7d9ce36e628e5f5f479bc07617a7bd9a9ad4d44c0d8abadf2e3eb62a11ce9743abc27b4ae8c20f709e72df4f25a7f
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 29, 2019
77939f2 Fix uninitialized g_connman crash in Shutdown() (MeshCollider) Pull request description: Fixes bitcoin#11312 As @dooglus pointed out, `g_connman` is uninitialized when an invalid wallet path is passed on start up, but then dereferenced in `Shutdown()`, so this tiny PR just fixes that. Tree-SHA512: 2557133422a6e393017081450a7e6c100fe7d9ce36e628e5f5f479bc07617a7bd9a9ad4d44c0d8abadf2e3eb62a11ce9743abc27b4ae8c20f709e72df4f25a7f
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
77939f2 Fix uninitialized g_connman crash in Shutdown() (MeshCollider) Pull request description: Fixes bitcoin#11312 As @dooglus pointed out, `g_connman` is uninitialized when an invalid wallet path is passed on start up, but then dereferenced in `Shutdown()`, so this tiny PR just fixes that. Tree-SHA512: 2557133422a6e393017081450a7e6c100fe7d9ce36e628e5f5f479bc07617a7bd9a9ad4d44c0d8abadf2e3eb62a11ce9743abc27b4ae8c20f709e72df4f25a7f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11312
As @dooglus pointed out,
g_connmanis uninitialized when an invalid wallet path is passed on start up, but then dereferenced inShutdown(), so this tiny PR just fixes that.