Skip to content

[depends] miniupnpc 2.0.20170509 #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2017
Merged

[depends] miniupnpc 2.0.20170509 #10414

merged 1 commit into from
May 17, 2017

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented May 17, 2017 •
edited
Loading

Update miniupnpc to 2.0.20170509.
See recent CVE-2017-8798
Fixed in miniupnpc - miniupnp/miniupnp@f0f1f4b

@fanquake fanquake requested a review from theuni May 17, 2017 09:46
@laanwj
Copy link
Member

laanwj commented May 17, 2017

utACK af5d48c

Probably want to backport this too because of the CVE-2017-8798.

@jonasschnelli
Copy link
Contributor

Tested ACK af5d48c
Build over gitian works.
https://bitcoin.jonasschnelli.ch/build/138

theuni
theuni approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK af5d48c

@laanwj laanwj merged commit af5d48c into bitcoin:master May 17, 2017
laanwj added a commit that referenced this pull request May 17, 2017
@laanwj
Merge #10414: [depends] miniupnpc 2.0.20170509
e61fc2d 
af5d48c [depends] miniupnpc 2.0.20170509 (fanquake)

Tree-SHA512: e6cfa7856aa4ceb17de5e84156cdb90094eedfb08a84ba1cd9a5ce1689533e17863e3f5692a1b7b7b096a7ac88f18539e4b6b7a79f7726401effb11bf9a5ef2f
laanwj pushed a commit that referenced this pull request May 17, 2017
@fanquake @laanwj
[depends] miniupnpc 2.0.20170509
ffb0c4b 
Github-Pull: #10414
Rebased-From: af5d48c
laanwj pushed a commit that referenced this pull request May 17, 2017
@fanquake @laanwj
[depends] miniupnpc 2.0.20170509
8adf75e 
Github-Pull: #10414
Rebased-From: af5d48c
@fanquake fanquake deleted the depends-miniupnpc-2-0-20170509 branch May 18, 2017 12:15
@bitcartel bitcartel mentioned this pull request Jul 1, 2017
Closed
@dagurval dagurval mentioned this pull request Jul 3, 2017
Merged
nomnombtc pushed a commit to nomnombtc/bitcoin that referenced this pull request Jul 17, 2017
@fanquake @nomnombtc
[depends] miniupnpc 2.0.20170509
5b2be98 
Github-Pull: bitcoin#10414
Rebased-From: af5d48c
codablock pushed a commit to codablock/dash that referenced this pull request Jan 26, 2018
@laanwj @codablock
Merge bitcoin#10414: [depends] miniupnpc 2.0.20170509
12099e5 
af5d48c [depends] miniupnpc 2.0.20170509 (fanquake)

Tree-SHA512: e6cfa7856aa4ceb17de5e84156cdb90094eedfb08a84ba1cd9a5ce1689533e17863e3f5692a1b7b7b096a7ac88f18539e4b6b7a79f7726401effb11bf9a5ef2f
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@laanwj @CryptoCentric
Merge bitcoin#10414: [depends] miniupnpc 2.0.20170509
3a88f82 
af5d48c [depends] miniupnpc 2.0.20170509 (fanquake)

Tree-SHA512: e6cfa7856aa4ceb17de5e84156cdb90094eedfb08a84ba1cd9a5ce1689533e17863e3f5692a1b7b7b096a7ac88f18539e4b6b7a79f7726401effb11bf9a5ef2f
This was referenced May 6, 2019
Closed
Merged
laanwj added a commit that referenced this pull request Jul 29, 2019
@laanwj
Merge #15993: net: Drop support of the insecure miniUPnPc versions
b21acab 
59cb722 Update configure to reject unsafe miniUPnPc API ver (Hennadii Stepanov)
ab21905 doc: Add release notes for 15993 (Hennadii Stepanov)
02709e9 Align formatting with clang-format (Hennadii Stepanov)
91a1b85 Use PACKAGE_NAME in UPnP description (Hennadii Stepanov)
9f76e45 Drop support of insecure miniUPnPc versions (Hennadii Stepanov)

Pull request description:

  1. Minimum supported miniUPnPc API version is set to 10:
  - https://packages.ubuntu.com/xenial/libminiupnpc-dev
  - https://packages.debian.org/jessie/libminiupnpc-dev

  Refs:
  - #6583
  - #6789
  - #10414

  2. The hardcoded "Bitcoin" replaced with `PACKAGE_NAME`:
  ![Screenshot from 2019-05-06 23-10-29](https://user-images.githubusercontent.com/32963518/57253178-afc60780-7056-11e9-83c9-e85670c58c1e.png)

  3. Also style-only commit applied.

  Pardon: could not reopen my previous PR #15966.

ACKs for top commit:
  ryanofsky:
    utACK 59cb722. Changes since last review: adding a new commit which updates configure script to fall back to disabling upnp if version is too old, adding a requested comment explaining static_assert condition, and fixing a spelling (jessy/jessie)

Tree-SHA512: 42ed11bc2fb2ec83d5dd58e2383da5444a24fd572707f6cf10b622cb8943e28adfcca4750d06801024c4472625b5ea9279516fbd9d2ccebc9bbaafe1d148e80d
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 30, 2019
@laanwj @sidhujag
Merge bitcoin#15993: net: Drop support of the insecure miniUPnPc vers…
1f6ab18 
…ions

59cb722 Update configure to reject unsafe miniUPnPc API ver (Hennadii Stepanov)
ab21905 doc: Add release notes for 15993 (Hennadii Stepanov)
02709e9 Align formatting with clang-format (Hennadii Stepanov)
91a1b85 Use PACKAGE_NAME in UPnP description (Hennadii Stepanov)
9f76e45 Drop support of insecure miniUPnPc versions (Hennadii Stepanov)

Pull request description:

  1. Minimum supported miniUPnPc API version is set to 10:
  - https://packages.ubuntu.com/xenial/libminiupnpc-dev
  - https://packages.debian.org/jessie/libminiupnpc-dev

  Refs:
  - bitcoin#6583
  - bitcoin#6789
  - bitcoin#10414

  2. The hardcoded "Bitcoin" replaced with `PACKAGE_NAME`:
  ![Screenshot from 2019-05-06 23-10-29](https://user-images.githubusercontent.com/32963518/57253178-afc60780-7056-11e9-83c9-e85670c58c1e.png)

  3. Also style-only commit applied.

  Pardon: could not reopen my previous PR bitcoin#15966.

ACKs for top commit:
  ryanofsky:
    utACK 59cb722. Changes since last review: adding a new commit which updates configure script to fall back to disabling upnp if version is too old, adding a requested comment explaining static_assert condition, and fixing a spelling (jessy/jessie)

Tree-SHA512: 42ed11bc2fb2ec83d5dd58e2383da5444a24fd572707f6cf10b622cb8943e28adfcca4750d06801024c4472625b5ea9279516fbd9d2ccebc9bbaafe1d148e80d
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 26, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15993: net: Drop support of the insecure miniUPnPc vers…
d8925fe 
…ions

59cb722 Update configure to reject unsafe miniUPnPc API ver (Hennadii Stepanov)
ab21905 doc: Add release notes for 15993 (Hennadii Stepanov)
02709e9 Align formatting with clang-format (Hennadii Stepanov)
91a1b85 Use PACKAGE_NAME in UPnP description (Hennadii Stepanov)
9f76e45 Drop support of insecure miniUPnPc versions (Hennadii Stepanov)

Pull request description:

  1. Minimum supported miniUPnPc API version is set to 10:
  - https://packages.ubuntu.com/xenial/libminiupnpc-dev
  - https://packages.debian.org/jessie/libminiupnpc-dev

  Refs:
  - dashpay#6583
  - dashpay#6789
  - bitcoin#10414

  2. The hardcoded "Bitcoin" replaced with `PACKAGE_NAME`:
  ![Screenshot from 2019-05-06 23-10-29](https://user-images.githubusercontent.com/32963518/57253178-afc60780-7056-11e9-83c9-e85670c58c1e.png)

  3. Also style-only commit applied.

  Pardon: could not reopen my previous PR bitcoin#15966.

ACKs for top commit:
  ryanofsky:
    utACK 59cb722. Changes since last review: adding a new commit which updates configure script to fall back to disabling upnp if version is too old, adding a requested comment explaining static_assert condition, and fixing a spelling (jessy/jessie)

Tree-SHA512: 42ed11bc2fb2ec83d5dd58e2383da5444a24fd572707f6cf10b622cb8943e28adfcca4750d06801024c4472625b5ea9279516fbd9d2ccebc9bbaafe1d148e80d
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 26, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15993: net: Drop support of the insecure miniUPnPc vers…
30b1e1d 
…ions

59cb722 Update configure to reject unsafe miniUPnPc API ver (Hennadii Stepanov)
ab21905 doc: Add release notes for 15993 (Hennadii Stepanov)
02709e9 Align formatting with clang-format (Hennadii Stepanov)
91a1b85 Use PACKAGE_NAME in UPnP description (Hennadii Stepanov)
9f76e45 Drop support of insecure miniUPnPc versions (Hennadii Stepanov)

Pull request description:

  1. Minimum supported miniUPnPc API version is set to 10:
  - https://packages.ubuntu.com/xenial/libminiupnpc-dev
  - https://packages.debian.org/jessie/libminiupnpc-dev

  Refs:
  - dashpay#6583
  - dashpay#6789
  - bitcoin#10414

  2. The hardcoded "Bitcoin" replaced with `PACKAGE_NAME`:
  ![Screenshot from 2019-05-06 23-10-29](https://user-images.githubusercontent.com/32963518/57253178-afc60780-7056-11e9-83c9-e85670c58c1e.png)

  3. Also style-only commit applied.

  Pardon: could not reopen my previous PR bitcoin#15966.

ACKs for top commit:
  ryanofsky:
    utACK 59cb722. Changes since last review: adding a new commit which updates configure script to fall back to disabling upnp if version is too old, adding a requested comment explaining static_assert condition, and fixing a spelling (jessy/jessie)

Tree-SHA512: 42ed11bc2fb2ec83d5dd58e2383da5444a24fd572707f6cf10b622cb8943e28adfcca4750d06801024c4472625b5ea9279516fbd9d2ccebc9bbaafe1d148e80d
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 26, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15993: net: Drop support of the insecure miniUPnPc vers…
6e054f8 
…ions

59cb722 Update configure to reject unsafe miniUPnPc API ver (Hennadii Stepanov)
ab21905 doc: Add release notes for 15993 (Hennadii Stepanov)
02709e9 Align formatting with clang-format (Hennadii Stepanov)
91a1b85 Use PACKAGE_NAME in UPnP description (Hennadii Stepanov)
9f76e45 Drop support of insecure miniUPnPc versions (Hennadii Stepanov)

Pull request description:

  1. Minimum supported miniUPnPc API version is set to 10:
  - https://packages.ubuntu.com/xenial/libminiupnpc-dev
  - https://packages.debian.org/jessie/libminiupnpc-dev

  Refs:
  - dashpay#6583
  - dashpay#6789
  - bitcoin#10414

  2. The hardcoded "Bitcoin" replaced with `PACKAGE_NAME`:
  ![Screenshot from 2019-05-06 23-10-29](https://user-images.githubusercontent.com/32963518/57253178-afc60780-7056-11e9-83c9-e85670c58c1e.png)

  3. Also style-only commit applied.

  Pardon: could not reopen my previous PR bitcoin#15966.

ACKs for top commit:
  ryanofsky:
    utACK 59cb722. Changes since last review: adding a new commit which updates configure script to fall back to disabling upnp if version is too old, adding a requested comment explaining static_assert condition, and fixing a spelling (jessy/jessie)

Tree-SHA512: 42ed11bc2fb2ec83d5dd58e2383da5444a24fd572707f6cf10b622cb8943e28adfcca4750d06801024c4472625b5ea9279516fbd9d2ccebc9bbaafe1d148e80d
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@theuni theuni theuni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fanquake @laanwj @jonasschnelli @theuni