[wallet] [moveonly] Check non-null pindex before potentially referencing #10265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
|
utACK 6b816dc. I am surprised there were no more bug report about that. |
|
@kallewoof I would go with temptation and move the |
|
@mchrostowski Did you mean 1545 by any chance? |
|
Concept ACK |
6b816dc to
c36ea69
Compare
|
This PR is now a MOVEONLY. 4 lines moved up to L1547-1550 from L1560-1563. |
|
utACK c36ea69 |
laanwj
added a commit
that referenced
this pull request
Apr 25, 2017
…ially referencing c36ea69 [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm) Tree-SHA512: a14c9f3e1228bca91977bea821c56a377d80889b41d250050c9be67aa93e460319a7cf1d4b63ee40f23b5a34159590f0e3fe15dc88698dc694c0c8098bd2db4d
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
…LogPrintf call. Github-Pull: bitcoin#10265 Rebased-From: c36ea69
nomnombtc
pushed a commit
to nomnombtc/bitcoin
that referenced
this pull request
Jul 17, 2017
…LogPrintf call. Github-Pull: bitcoin#10265 Rebased-From: c36ea69
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 26, 2018
… potentially referencing c36ea69 [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm) Tree-SHA512: a14c9f3e1228bca91977bea821c56a377d80889b41d250050c9be67aa93e460319a7cf1d4b63ee40f23b5a34159590f0e3fe15dc88698dc694c0c8098bd2db4d
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
… potentially referencing c36ea69 [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm) Tree-SHA512: a14c9f3e1228bca91977bea821c56a377d80889b41d250050c9be67aa93e460319a7cf1d4b63ee40f23b5a34159590f0e3fe15dc88698dc694c0c8098bd2db4d
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
… potentially referencing c36ea69 [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm) Tree-SHA512: a14c9f3e1228bca91977bea821c56a377d80889b41d250050c9be67aa93e460319a7cf1d4b63ee40f23b5a34159590f0e3fe15dc88698dc694c0c8098bd2db4d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The once-a-minute
LogPrintfinScanForWalletTransactionswill do a null-ref if it happens to hit the 60s mark right at the last block (wherepindexbecomesnull). This was moved up to the top of the block instead, where thewhile (pindex && !fAbortRescan)has checkedpindexfor us.