Fix some empty vector references #10250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this.
|
utACK f478d98 |
|
utACK f478d98 |
|
utACK f478d98 |
laanwj
added a commit
that referenced
this pull request
Apr 21, 2017
f478d98 Fix some empty vector references (Pieter Wuille) Tree-SHA512: a22022b9060cd39f8d349e8dd24490614c0028eae2fbc7186d0d26b1d47529049b2daee41f093c0722130274a0b6f7f8671c2295c8cb4a97028771eaff080734
|
post-merge utACK f478d98 |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this. Github-Pull: bitcoin#10250 Rebased-From: f478d98
nomnombtc
pushed a commit
to nomnombtc/bitcoin
that referenced
this pull request
Jul 17, 2017
streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this. Github-Pull: bitcoin#10250 Rebased-From: f478d98
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 31, 2017
f478d98 Fix some empty vector references (Pieter Wuille) Tree-SHA512: a22022b9060cd39f8d349e8dd24490614c0028eae2fbc7186d0d26b1d47529049b2daee41f093c0722130274a0b6f7f8671c2295c8cb4a97028771eaff080734
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
May 3, 2018
Closes #3182 - Least Authority Issue D Prevent undefined behaviour when null pointer is passed in as parameter to function Includes a backport of bitcoin/bitcoin#10250.
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 12, 2020
…tors in streams 9f39dc8 Switch CCoinsMap from boost to std unordered_map (Pieter Wuille) 2f58a63 Add support for std::unordered_{map,set} to memusage.h (Pieter Wuille) 60c8cef Fix some empty vector references (random-zebra) Pull request description: Couple of quick backports (needed for the upcoming per-txout model for cache and chainstate db): - bitcoin#10249 - Switch CCoinsMap from boost to std unordered_map - bitcoin#10250 - Fix some empty vector references ACKs for top commit: furszy: utACK 9f39dc8 Fuzzbawls: ACK 9f39dc8 Tree-SHA512: 9af7ad25d0066883a42ccacc26252fded20b80a875a6e282ea173a484031da9c2719c1feec699157aa22774d13c241f5c21312a8e38749d67c9c8c2e2ff592cb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this. This problem does not manifest in practice (yet), it seems.
Discovered by @theuni.