-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Add address to listtransactions output #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Sep 18, 2011
Closed
dasher
referenced
this pull request
in dasher/litecoin
Nov 12, 2012
dasher
referenced
this pull request
in dasher/litecoin
Dec 18, 2012
nelisky
pushed a commit
to nelisky/bitcoin
that referenced
this pull request
Sep 25, 2013
justmoon
pushed a commit
to justmoon/bitcoin
that referenced
this pull request
Apr 7, 2014
… constructor and throws if it cannot lock the lock file. This commit closes bitcoin#10
Closed
sensorii
pushed a commit
to sensorii/mazacoin-new
that referenced
this pull request
Sep 27, 2014
Added new testnet genesis block and start DGW3 fork at block 10
kac-
pushed a commit
to kac-/peercoin-ce
that referenced
this pull request
Oct 8, 2014
…BitcoinMiner(). This fixes an assertion failure crash when starting ppcoin-qt. The assertion failure is caused by a static call to the _() function. The issue is fixed by making strMintMessage a non-static local variable inside BitcoinMiner(). Assertion failure message (from Sunny): ppcoin-qt: /usr/include/boost/smart_ptr/shared_ptr.hpp:412: boost::shared_ptr<T>::reference boost::shared_ptr<T>::operator*() const [ with T = <snip> ]: Assertion `px != 0' failed. Backtrace of the crash: #0 0x0000003565435309 in raise () from /lib64/libc.so.6 #1 0x0000003565436668 in abort () from /lib64/libc.so.6 #2 0x000000356542e476 in __assert_fail_base () from /lib64/libc.so.6 bitcoin#3 0x000000356542e522 in __assert_fail () from /lib64/libc.so.6 bitcoin#4 0x0000000000475dbe in operator* (this=<optimized out>) at /usr/include/boost/smart_ptr/shared_ptr.hpp:646 bitcoin#5 operator() (arg1=0x649fd8 "Info: Minting suspended due to locked wallet.", this=<optimized out>) at /usr/include/boost/signals2/detail/signal_template.hpp:695 bitcoin#6 _ (psz=psz@entry=0x649fd8 "Info: Minting suspended due to locked wallet.") at src/ui_interface.h:106 bitcoin#7 0x000000000049f5f7 in __static_initialization_and_destruction_0 (__initialize_p=__initialize_p@entry=1, __priority=__priority@entry=65535) at src/main.cpp:3345 bitcoin#8 0x00000000004af11a in _GLOBAL__sub_I_cs_setpwalletRegistered () at src/main.cpp:5303 bitcoin#9 0x0000000000620d0d in __libc_csu_init () bitcoin#10 0x0000003565421aa5 in __libc_start_main () from /lib64/libc.so.6 bitcoin#11 0x000000000042b9f8 in _start ()
TheBlueMatt
referenced
this pull request
in TheBlueMatt/bitcoin
Oct 20, 2015
Update README with different mainchain branch name
brishtiteveja
pushed a commit
to brishtiteveja/truthcoin-cpp
that referenced
this pull request
Jan 25, 2016
Update README.md
tempgit9
pushed a commit
to tempgit9/bitcoin
that referenced
this pull request
Jan 16, 2017
AkioNak
pushed a commit
to AkioNak/bitcoin
that referenced
this pull request
Jul 24, 2017
[miner] [leak] shrinkingsets are now properly cleaned up on destruction.
laanwj
pushed a commit
that referenced
this pull request
Aug 2, 2017
c521b3a Merge #11: fixup define checks. Cleans up some oopses from #5. 8b1cd37 fixup define checks. Cleans up some oopses from #5. 6b1508d Merge #6: Fixes typo fceb805 Merge #10: Clean up compile-time warnings (gcc 7.1) 0ec2a34 Clean up compile-time warnings (gcc 7.1) d4c268a Merge #5: Move helper functions out of sse4.2 object 8d4eb08 Add HasAcceleratedCRC32C to port_win.h 77cfbfd25 crc32: move helper functions out of port_posix_sse.cc 4c1e9e0 silence compiler warnings about uninitialized variables 4953164 Merge #2: Prefer std::atomic over MemoryBarrier 2953978 Fixes typo f134284 Merge #1: Merge upstream LevelDB 1.20 ba8a445 Prefer std::atomic over MemoryBarrier git-subtree-dir: src/leveldb git-subtree-split: c521b3a
CryptAxe
referenced
this pull request
in CryptAxe/bitcoin
Dec 28, 2017
CryptAxe
referenced
this pull request
in CryptAxe/bitcoin
Dec 28, 2017
maflcko
referenced
this pull request
in maflcko/bitcoin-core
Jan 15, 2018
maflcko
referenced
this pull request
in maflcko/bitcoin-core
Feb 10, 2018
hkjn
pushed a commit
to hkjn/bitcoin
that referenced
this pull request
Feb 12, 2018
Willtech
pushed a commit
to Willtech/bitcoin
that referenced
this pull request
Feb 23, 2018
HashUnlimited
referenced
this pull request
in chaincoin/chaincoin
Mar 9, 2018
c521b3a Merge #11: fixup define checks. Cleans up some oopses from #5. 8b1cd37 fixup define checks. Cleans up some oopses from #5. 6b1508d Merge #6: Fixes typo fceb805 Merge #10: Clean up compile-time warnings (gcc 7.1) 0ec2a34 Clean up compile-time warnings (gcc 7.1) d4c268a Merge #5: Move helper functions out of sse4.2 object 8d4eb08 Add HasAcceleratedCRC32C to port_win.h 77cfbfd25 crc32: move helper functions out of port_posix_sse.cc 4c1e9e0 silence compiler warnings about uninitialized variables 4953164 Merge #2: Prefer std::atomic over MemoryBarrier 2953978 Fixes typo f134284 Merge #1: Merge upstream LevelDB 1.20 ba8a445 Prefer std::atomic over MemoryBarrier git-subtree-dir: src/leveldb git-subtree-split: c521b3a
KrzysiekJ
pushed a commit
to KrzysiekJ/bitcoin
that referenced
this pull request
Mar 28, 2018
Add autocomplete to bitcoin-qt's console window.
jc23424
pushed a commit
to jc23424/bitcoin
that referenced
this pull request
Jun 9, 2018
Add README information and build instructions
effectsToCause
referenced
this pull request
in VeriumReserve/verium
Jun 22, 2018
Remove redundant if in hashrate calculation
maflcko
pushed a commit
that referenced
this pull request
Jul 30, 2018
6f53edb Acquire cs_main before ATMP call in block_assemble bench (James O'Beirne) Pull request description: Calling `bench_bitcoin` currently fails due to calling ATMP without acquiring cs_main first in the recently added block_assemble bench (#13219). ``` $ cat <(uname -a) <(gcc --version) Linux james 4.4.0-119-generic #143+jamesob SMP Mon Apr 16 21:47:24 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 $ ./src/bench/bench_bitcoin WARNING: This is a debug build - may result in slower benchmarks. # Benchmark, evals, iterations, total, min, max, median Assertion failed: lock cs_main not held in validation.cpp:566; locks held: [1] 19323 abort (core dumped) ./src/bench/bench_bitcoin ``` ``` (gdb) bt #0 0x00007fbdc9cf5428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x00007fbdc9cf702a in __GI_abort () at abort.c:89 #2 0x0000555a19580dc5 in AssertLockHeldInternal (pszName=pszName@entry=0x555a19834549 "cs_main", pszFile=pszFile@entry=0x555a1988a001 "validation.cpp", nLine=nLine@entry=566, cs=cs@entry=0x555a19ba55c0 <cs_main>) at sync.cpp:157 #3 0x0000555a194b395f in AcceptToMemoryPoolWorker (chainparams=..., pool=..., state=..., ptx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=1532964079, plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=@0x7ffcbc1719d8: 0, coins_to_uncache=std::vector of length 0, capacity 0, test_accept=false) at validation.cpp:566 #4 0x0000555a194ba661 in AcceptToMemoryPoolWithTime (chainparams=..., pool=..., state=..., tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=<optimized out>, plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=0, test_accept=false) at validation.cpp:998 #5 0x0000555a194ba7ce in AcceptToMemoryPool (pool=..., state=..., tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, plTxnReplaced=plTxnReplaced@entry=0x0, bypass_limits=bypass_limits@entry=false, nAbsurdFee=0, test_accept=false) at validation.cpp:1014 #6 0x0000555a19363fbe in AssembleBlock (state=...) at bench/block_assemble.cpp:102 #7 0x0000555a193654d3 in std::_Function_handler<void (benchmark::State&), void (*)(benchmark::State&)>::_M_invoke(std::_Any_data const&, benchmark::State&) (__functor=..., __args#0=...) at /usr/include/c++/5/functional:1871 #8 0x0000555a193501d7 in std::function<void (benchmark::State&)>::operator()(benchmark::State&) const (this=this@entry=0x555a1ba2cda0, __args#0=...) at /usr/include/c++/5/functional:2267 #9 0x0000555a1934ec4c in benchmark::BenchRunner::RunAll (printer=..., num_evals=5, scaling=<optimized out>, filter=..., is_list_only=false) at bench/bench.cpp:121 #10 0x0000555a1934ade9 in main (argc=<optimized out>, argv=<optimized out>) at bench/bench_bitcoin.cpp:92 ``` Tree-SHA512: fdd7b28ff123ccea7a4f334d53f735d0c0f94aa9cc52520c2dd34dca45d78c691af64efcd32366fc472fedffbd79591d2be2bb3bfc4a5186e8712b6b452d64e3
dooglus
pushed a commit
to dooglus/bitcoin
that referenced
this pull request
Oct 21, 2018
Add constructor to make legacy block from regular block. Use it to ma…
cryptapus
added a commit
to cryptapus/bitcoin
that referenced
this pull request
Jan 23, 2019
…lease set release true
maflcko
pushed a commit
that referenced
this pull request
Mar 8, 2021
e21276a qt test: Don't bind to regtest port (Andrew Chow) Pull request description: The qt tests don't need to bind to the regtest port. By not binding, it will no longer conflict with existing regtest instances and the tests will run as normal. Fixes #10 ACKs for top commit: MarcoFalke: cr ACK e21276a jarolrod: re-ACK e21276a, tested on macOS 11.2 Tree-SHA512: 5a269ee043f9aff7900e092c166de71912a2bf86ebe2982b3fb0e26bdebfb91869ee5d0f62082fd608c1288bfb7981f6c8647e504b11176711d7fec993a09164
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes to listtransactions:
Add address to listtransactions output.
"multisends" (non-standard, use one transaction to send to multiple addresses) generate N "category":"send" lines.
Bug fix: listtransactions wasn't reporting pay-by-IP-connection receive transactions.