test: Run rpc_txoutproof.py even with wallet disabled #19922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2020 10:38
…o_to_spend Adds two new features to MiniWallet: * The fee rate is irrelevant sometimes, so just set an arbitrary default * The utxo to spend needs to be selected manually sometimes
|
Concept ACK. Moving all the remaining non-wallet tests to use MiniWallet could be a good first issue for newer contributors. |
d34380f to
faf251d
Compare
|
Force pushed to make travis python linter happy |
|
utACK faf251d. Thanks Marco! |
kristapsk
approved these changes
Sep 10, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 11, 2020
…abled faf251d test: gettxoutproof duplicate txid (João Barbosa) faf5eb4 test: Test empty array in gettxoutproof (MarcoFalke) fa56e86 test: Run rpc_txoutproof.py even with wallet disabled (MarcoFalke) faba790 test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend (MarcoFalke) fa65a11 test: bugfix: Actually pick largest utxo (MarcoFalke) Pull request description: Run the consensus test even when the wallet was not compiled. Also: * Minor bugfix in MiniWallet * Two new test cases (one cherry-picked from bitcoin#19847) ACKs for top commit: jnewbery: utACK faf251d. Thanks Marco! kristapsk: ACK faf251d Tree-SHA512: a5ab33695c88cfb3c369021d4506069c08ce298e24e891db55159130693ed3817444c72f6aad3f472235aa4597b2c601010af714411c2ec8ad9c2d2e0b00ecbc
|
@MarcoFalke I realize that this is a merged PR, but I just had some hanging issues/comments regarding implementing |
|
|
Alright, I will open a PR soon with respected changes. Thank you :) |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 11, 2021
Summary: This brings the test duration down from 2 seconds to 1 second. This is a backport of [[bitcoin/bitcoin#19922 | core#19922]] [2/4] bitcoin/bitcoin@fa56e86 Depends on D10254 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10255
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 11, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19922 | core#19922]] [3/4] bitcoin/bitcoin@faf5eb4 Depends on D10255 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10256
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 11, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19922 | core#19922]] [4/4] bitcoin/bitcoin@faf251d Depends on D10256 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10257
PiRK
pushed a commit
to PiRK/lotusd
that referenced
this pull request
Aug 16, 2022
Summary: This brings the test duration down from 2 seconds to 1 second. This is a backport of [[bitcoin/bitcoin#19922 | core#19922]] [2/4] bitcoin/bitcoin@fa56e86 Depends on D10254 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10255
PiRK
pushed a commit
to PiRK/lotusd
that referenced
this pull request
Aug 16, 2022
Summary: This is a backport of [[bitcoin/bitcoin#19922 | core#19922]] [3/4] bitcoin/bitcoin@faf5eb4 Depends on D10255 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10256
PiRK
pushed a commit
to PiRK/lotusd
that referenced
this pull request
Aug 16, 2022
Summary: This is a backport of [[bitcoin/bitcoin#19922 | core#19922]] [4/4] bitcoin/bitcoin@faf251d Depends on D10256 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10257
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the consensus test even when the wallet was not compiled. Also: