Looks like this is adding a lot of code (complexity). Not sure if that is worth it.

Looks like this is adding a lot of code (complexity). Not sure if that is worth it.

Since the memory unused by the mempool could be used by the coinscache, CTxMemPool::DynamicMemoryUsage() is buried in CChainState::GetCoinsCacheSizeState(). The code could be much simpler if every entity will have its own memory limit.

@MarcoFalke

Not sure if that is worth it.

http://www.erisian.com.au/bitcoin-core-dev/log-2020-06-18.html#l-16:

<sipa> recursive mutexes are evil

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• refactor: Move node and wallet code out of src/interfaces #20494 (refactor: Move node and wallet code out of src/interfaces by ryanofsky)
• multiprocess: Add bitcoin-gui -ipcconnect option #19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
• multiprocess: Add bitcoin-wallet -ipcconnect option #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
• multiprocess: Add basic spawn and IPC support #19160 (multiprocess: Add basic spawn and IPC support by ryanofsky)
• Multiprocess bitcoin #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}