Avoid locking CTxMemPool::cs recursively in Mempool{Info}ToJSON() #19652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
|
Concept ACK: thanks for adding thread-safety annotations! |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Aug 3, 2020
|
Rebased ef803c3 -> dd427dd (pr19652.02 -> pr19652.03) due to the conflict with #19572. |
This change avoids locking CTxMemPool::cs recursively in
Mempool{Info}ToJSON() functions.
|
Rebased dd427dd -> 09b1ef2 (pr19652.03 -> pr19652.04) due to the conflict with #18766. |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #19306.
Only trivial thread safety annotations and lock assertions added. No new locks. No behavior change.
This is a step to make
CTxMemPool::csan instance ofMutexratherRecursiveMutex.