doc: update PyZMQ install instructions, fix zmq_sub.py file permissions #19870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Sep 4, 2020
9e18609 to
062e669
Compare
|
If I'm not mistaken, |
theStack
approved these changes
Sep 6, 2020
There was a problem hiding this comment.
ACK 062e669 🧷
Checked that the changed/introduced URLs are visitable and correct and that the PyZMQ install instruction via pip works (tested in Ubuntu Xenial). Also ran the zmq_sub.py script directly to double-check that the execution flag is set now.
fanquake
approved these changes
Sep 11, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 11, 2020
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 27, 2021
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 28, 2021
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 29, 2021
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 16, 2021
…sub.py file permissions 062e669 script: fix zmq_sub.py file permissions (Jon Atack) 36f8e0c doc: update PyZMQ installation instructions, ZeroMQ link (Jon Atack) Pull request description: Seen while reviewing bitcoin#19572. ACKs for top commit: theStack: ACK 062e669 🧷 fanquake: ACK 062e669 Tree-SHA512: 2210d92385377d066984d0a83882c3ece9f0f41c901b7eb375af9cdb57296f50f227c68193ccf35926073c2b788d58976442791a9fce2fc0f76452804d5cee6a
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 1, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19870 | core#19870]] Test Plan: Tested link and `pyzmq` installation instruction Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10232
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen while reviewing #19572.