build: Fix target name #19868
Merged
build: Fix target name #19868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2020
|
cc @icota |
|
Your PR description is a bit terse. Can you please explain why you think it was a typo, and why it is correct alternative to that other commit? |
Because of the initial intention of this line that is expressed in the comment: Line 267 in 3eb789c |
|
@hebasto is absolutely correct here. Thanks for tracking this down! From IRC Build meeting today: So Concept ACK, but I think it should be |
3eb789c to
7a89f2e
Compare
|
Updated 3eb789c -> 7a89f2e (pr19868.01 -> pr19868.02, diff):
|
|
tACK 7a89f2e |
|
I was a bit hesitant to simply "fix" this typo, since the intended behavior has never actually executed. But it seems that the intended behavior was necessary and correct after all. Lightly tested locally, corner cases like ACK 7a89f2e. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 23, 2020
7a89f2e build: Fix target name (Hennadii Stepanov) Pull request description: It seems like a typo :) This PR: - fixes errors when building a package in depends for `HOST=x86_64-apple-darwin16` (fix bitcoin#19799) - is a correct alternative to bitcoin@d25e0e3 from bitcoin#19764 ACKs for top commit: icota: tACK bitcoin@7a89f2e dongcarl: Code Review ACK 7a89f2e theuni: ACK 7a89f2e. Tree-SHA512: a0bcbc6805d3450e201476ef1e22e0eb53903db1586c5515314c19afd337bded887e56de0fbe62feaf359b2de15dbccd49a44f1a8b566b4c64f5ae3d94a2ab6d
Gitian builds
|
|
Was wondering why the Windows builds seemed to fail here, but turns out the bot just ran out of space: + find bitcoin-475d0ad3f464/bin -type f -executable -print0
/usr/bin/x86_64-w64-mingw32-objcopy:bitcoin-475d0ad3f464/bin/test_bitcoin.exe.dbg[.debug_info]: No space left on device |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 17, 2021
7a89f2e build: Fix target name (Hennadii Stepanov) Pull request description: It seems like a typo :) This PR: - fixes errors when building a package in depends for `HOST=x86_64-apple-darwin16` (fix bitcoin#19799) - is a correct alternative to bitcoin@d25e0e3 from bitcoin#19764 ACKs for top commit: icota: tACK bitcoin@7a89f2e dongcarl: Code Review ACK 7a89f2e theuni: ACK 7a89f2e. Tree-SHA512: a0bcbc6805d3450e201476ef1e22e0eb53903db1586c5515314c19afd337bded887e56de0fbe62feaf359b2de15dbccd49a44f1a8b566b4c64f5ae3d94a2ab6d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 24, 2021
7a89f2e build: Fix target name (Hennadii Stepanov) Pull request description: It seems like a typo :) This PR: - fixes errors when building a package in depends for `HOST=x86_64-apple-darwin16` (fix bitcoin#19799) - is a correct alternative to bitcoin@d25e0e3 from bitcoin#19764 ACKs for top commit: icota: tACK bitcoin@7a89f2e dongcarl: Code Review ACK 7a89f2e theuni: ACK 7a89f2e. Tree-SHA512: a0bcbc6805d3450e201476ef1e22e0eb53903db1586c5515314c19afd337bded887e56de0fbe62feaf359b2de15dbccd49a44f1a8b566b4c64f5ae3d94a2ab6d
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Oct 12, 2021
7a89f2e build: Fix target name (Hennadii Stepanov) Pull request description: It seems like a typo :) This PR: - fixes errors when building a package in depends for `HOST=x86_64-apple-darwin16` (fix bitcoin#19799) - is a correct alternative to bitcoin@d25e0e3 from bitcoin#19764 ACKs for top commit: icota: tACK bitcoin@7a89f2e dongcarl: Code Review ACK 7a89f2e theuni: ACK 7a89f2e. Tree-SHA512: a0bcbc6805d3450e201476ef1e22e0eb53903db1586c5515314c19afd337bded887e56de0fbe62feaf359b2de15dbccd49a44f1a8b566b4c64f5ae3d94a2ab6d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a typo :)
This PR:
HOST=x86_64-apple-darwin16(fix build: Error when bulding a package in depends for HOST=x86_64-apple-darwin16 #19799)