Skip to content

Conversation

marcinja
Copy link
Contributor

Moves CDiskTxPos it its own file so it can be used without the txindex.h include elsewhere. Originally part of #14053.

Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7668db3.

#14053 adds src/index/addrindex.cpp which includes src/index/disktxpos.h.

@jnewbery
Copy link
Contributor

utACK 7668db3

@maflcko maflcko merged commit 1bc8e8e into bitcoin:master Aug 17, 2020
@laanwj
Copy link
Member

laanwj commented Aug 17, 2020

Posthumous ACK

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 18, 2020
7668db3 Move only: Move CDiskTxPos to its own file (Marcin Jachymiak)

Pull request description:

  Moves `CDiskTxPos` it its own file so it can be used without the `txindex.h` include elsewhere. Originally part of bitcoin#14053.

ACKs for top commit:
  jnewbery:
    utACK 7668db3
  promag:
    ACK 7668db3.

Tree-SHA512: b108e980ad04e43d1323410c3683a82bed70aee7795f5d8a2afbaf32a07ba598571f00b047bdde15048124b17178bcbd10654c48461beac988e9643cb2df664c
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 15, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19734 | core#19734]]

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10112
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 17, 2021
7668db3 Move only: Move CDiskTxPos to its own file (Marcin Jachymiak)

Pull request description:

  Moves `CDiskTxPos` it its own file so it can be used without the `txindex.h` include elsewhere. Originally part of bitcoin#14053.

ACKs for top commit:
  jnewbery:
    utACK 7668db3
  promag:
    ACK 7668db3.

Tree-SHA512: b108e980ad04e43d1323410c3683a82bed70aee7795f5d8a2afbaf32a07ba598571f00b047bdde15048124b17178bcbd10654c48461beac988e9643cb2df664c
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 20, 2021
7668db3 Move only: Move CDiskTxPos to its own file (Marcin Jachymiak)

Pull request description:

  Moves `CDiskTxPos` it its own file so it can be used without the `txindex.h` include elsewhere. Originally part of bitcoin#14053.

ACKs for top commit:
  jnewbery:
    utACK 7668db3
  promag:
    ACK 7668db3.

Tree-SHA512: b108e980ad04e43d1323410c3683a82bed70aee7795f5d8a2afbaf32a07ba598571f00b047bdde15048124b17178bcbd10654c48461beac988e9643cb2df664c
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 20, 2021
7668db3 Move only: Move CDiskTxPos to its own file (Marcin Jachymiak)

Pull request description:

  Moves `CDiskTxPos` it its own file so it can be used without the `txindex.h` include elsewhere. Originally part of bitcoin#14053.

ACKs for top commit:
  jnewbery:
    utACK 7668db3
  promag:
    ACK 7668db3.

Tree-SHA512: b108e980ad04e43d1323410c3683a82bed70aee7795f5d8a2afbaf32a07ba598571f00b047bdde15048124b17178bcbd10654c48461beac988e9643cb2df664c
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 22, 2021
7668db3 Move only: Move CDiskTxPos to its own file (Marcin Jachymiak)

Pull request description:

  Moves `CDiskTxPos` it its own file so it can be used without the `txindex.h` include elsewhere. Originally part of bitcoin#14053.

ACKs for top commit:
  jnewbery:
    utACK 7668db3
  promag:
    ACK 7668db3.

Tree-SHA512: b108e980ad04e43d1323410c3683a82bed70aee7795f5d8a2afbaf32a07ba598571f00b047bdde15048124b17178bcbd10654c48461beac988e9643cb2df664c
UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 24, 2021
kwvg pushed a commit to kwvg/dash that referenced this pull request Oct 12, 2021
7668db3 Move only: Move CDiskTxPos to its own file (Marcin Jachymiak)

Pull request description:

  Moves `CDiskTxPos` it its own file so it can be used without the `txindex.h` include elsewhere. Originally part of bitcoin#14053.

ACKs for top commit:
  jnewbery:
    utACK 7668db3
  promag:
    ACK 7668db3.

Tree-SHA512: b108e980ad04e43d1323410c3683a82bed70aee7795f5d8a2afbaf32a07ba598571f00b047bdde15048124b17178bcbd10654c48461beac988e9643cb2df664c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants