Could it be done with a scripted diff?

Beyond the question of whether this is a change worth making and worth the review time it is requesting, it looks like this PR is a drive-by search and replace that touches a number of files that are auto-generated or not usually changed.

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• torcontrol: Create also a V3 ed25519-V3 onion address. #19485 (torcontrol: Create also a V3 ed25519-V3 onion address. by Saibato)
• torcontrol : avoid to set wrong outbound proxy and network settings when creating an inbound onion service. #19358 (net: Make sure we do not override proxy settings in hidden service. by Saibato)
• fuzz: Add fuzzing harness for TorController #19288 (tests: Add fuzzing harness for TorController by practicalswift)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

thx @RiccardoMasutti , for pointing this out and I somewhat like this kind of compliance on paper since disguise is the sister of hidden,

tor source code;
./src/feature/rend/rendservice.h:

  /* Other fields */
  crypto_pk_t *private_key; /**< Permanent hidden-service key. */
  char service_id[REND_SERVICE_ID_LEN_BASE32+1]; /**< Onion address without
                                                  * '.onion' */
  char pk_digest[DIGEST_LEN]; /**< Hash of permanent hidden-service key. */
  smartlist_t *intro_nodes; /**< List of rend_intro_point_t's we have,
                             * or are trying to establish. */
  /** List of rend_intro_point_t that are expiring. They are removed once
   * the new descriptor is successfully uploaded. A node in this list CAN
   * NOT appear in the intro_nodes list. */

names it, what it should be ?

So imho facts become not that different by wording.
But as this is kind of compliance on paper and disguise the sister of hidden,
I somewhat like it.

The moment even
HiddenServiceDir parameter for use in torrc get renamed we should act.

Concept ACK. I think 'onion service' describes more concretely than 'hidden service' what is being talked about.

it looks like this PR is a drive-by search and replace that touches a number of files that are auto-generated or not usually changed.

Yes.

And please squash this into one commit when done.

Concept ACK assuming @laanwj's feedback is addressed

Welcome as a contributor @RiccardoMasutti! :)

You need to squash your changes into a single commit, and use a proper commit message. i.e:

doc: replace hidden service with onion service

For a couple of years, Tor documentation has made 
the term hidden service obsolete, in favor of onion 
service.

This PR updates all the references in the code base.

@fanquake @laanwj It should be okay now. Can you review it again please?

Ps: it's my first time squashing commits via git, and I'm really happy to have learned it. Usually I relied on GitHub repo maintainers who have the ability to squash and merge

ACK f2cd7a4 -- patch looks correct

Welcome as a contributor @RiccardoMasutti! :)

Yes and thanks for sticking with this, most admit that it's not really documented anywhere which files you are and are not allowed to change.

@laanwj ready to merge

Code review ACK 1e72b68