refactor: Pass ArgsManager into functions that register args #19561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3RK
commented
Jul 21, 2020
| @@ -341,8 +341,8 @@ class CRegTestParams : public CChainParams { | |||
|
|
|||
| void CRegTestParams::UpdateActivationParametersFromArgs(const ArgsManager& args) | |||
| { | |||
| if (gArgs.IsArgSet("-segwitheight")) { | |||
| int64_t height = gArgs.GetArg("-segwitheight", consensus.SegwitHeight); | |||
| if (args.IsArgSet("-segwitheight")) { | |||
There was a problem hiding this comment.
This line had been added when local args already existed. I couldn't find any reason for the use of global variable, but maybe I'm missing something.
|
scripted diffs shouldn't modify out-of-git-tree files. Please replace the wildcard; See other scripted diffs for examples. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 21, 2020
Closed
|
Concept ACK, apart from my feedback ofc |
|
Updated scripted diff to avoid touching out-of-tree files |
-BEGIN VERIFY SCRIPT- sed -i -e 's/gArgs.Add/argsman.Add/g' `git grep -l "gArgs.Add"` -END VERIFY SCRIPT-
This was referenced Jul 29, 2020
|
ACK 8ed9002 👛 Show signature and timestampSignature: Timestamp of file with hash |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 14, 2020
Summary: ``` Rationale: reduce use of gArgs to decouple code and simplify future maintenance and easier unit testing. This PR is continuation of work started in #18926 and #18662 It covers only places that register args in ArgsManager with AddArgs() or AddHiddenArgs(). ``` Backport of core [[bitcoin/bitcoin#19561 | PR19561]]. Depends on D8643. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8644
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: reduce use of gArgs to decouple code and simplify future maintenance and easier unit testing.
This PR is continuation of work started in #18926 and #18662
It covers only places that register args in ArgsManager with
AddArgs()orAddHiddenArgs().Closes #19511