refactor: Remove confusing BlockIndex global #19413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Nice change, good to get rid of an valdiation global, and it's surprisingly low impact. ACK fa82d84 |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK |
This was referenced Jun 29, 2020
fa82d84 to
fa0dfdf
Compare
promag
reviewed
Jul 3, 2020
jonatack
reviewed
Jul 3, 2020
domob1812
added a commit
to domob1812/namecoin-core
that referenced
this pull request
Jul 6, 2020
Some Namecoin code is still broken by the upstream change in bitcoin/bitcoin#19413, which will be fixed in a separate follow-up commit.
domob1812
added a commit
to domob1812/namecoin-core
that referenced
this pull request
Jul 6, 2020
Properly pass down a ChainstateManager to the parts of the Namecoin code that need it (mostly validation of the coin database and the mempool, which is partly based on block heights). This fixes the breakages introduced by the upstream removal of the global BlockIndex in bitcoin/bitcoin#19413.
domob1812
added a commit
to domob1812/namecoin-core
that referenced
this pull request
Jul 6, 2020
Properly pass down a ChainstateManager to the parts of the Namecoin code that need it (mostly validation of the coin database and the mempool, which is partly based on block heights). This fixes the breakages introduced by the upstream removal of the global BlockIndex in bitcoin/bitcoin#19413.
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 26, 2021
Summary: > The global ::BlockIndex() is problematic for several reasons: > - It returns a mutable reference to the block tree, without the appropriate lock annotation (m_block_index is guarded by cs_main). The current code is fine, but in the future this might lead to accidental races and data corruption. > - The rpc server shouldn't rely on node globals, but rather a context that is passed in to the RPC method. > - Tests might want to spin up their own block tree, and thus should also not rely on a single global. > > Fix all issues by removing the global This is a backport of [[bitcoin/bitcoin#19413 | core#19413]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D9581
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global
::BlockIndex()is problematic for several reasons:m_block_indexis guarded bycs_main). The current code is fine, but in the future this might lead to accidental races and data corruption.Fix all issues by removing the global