refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o) #19373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Nice cleanup.
almost-ACK 282df90 modulo when building the fuzzers
test/fuzz/decode_tx.cpp:17:39: error: no matching constructor for initialization of 'std::string' (aka 'basic_string<char>')
const std::string tx_hex = HexStr(std::string{buffer});
^ ~~~~~~~~
HexStr can be called with anything that bas `begin()` and `end()` functions, so clean up the redundant calls.
|
Thanks! |
|
ACK bd93e32
diff --git a/src/test/fuzz/decode_tx.cpp b/src/test/fuzz/decode_tx.cpp
@@ -14,7 +14,7 @@
void test_one_input(const std::vector<uint8_t>& buffer)
{
- const std::string tx_hex = HexStr(std::string{buffer});
+ const std::string tx_hex = HexStr(buffer);recalcitrant fuzzer is back in action |
|
ACK bd93e32 When running all of the fuzz tests, Looking forward to eventually being able to build the fuzz tests at the same time as everything else :) |
|
@troygiorshev maybe |
|
I ran review ACK bd93e32 🔌 Show signature and timestampSignature: Timestamp of file with hash |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 1, 2021
Summary: ``` HexStr can be called with anything that bas begin() and end() functions, so clean up the redundant calls. (context: I tried to convert HexStr to use span, but this turns out to be somewhat more involved than I thought, because of the limitation to pre-c++17 Span lacking iterator-based constructor) . This commit is a first step which stands on its own though) ``` Backport of core [[bitcoin/bitcoin#19373 | PR19373]]. Test Plan: ninja all check-all ninja bitcoin-fuzzers ./test/fuzz/test_runner.py <path_to_corpus> Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9122
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 8, 2021
Using GNU sed `sed -i --regexp-extended -e 's/HexStr\(([^(]+)\.begin\(\), *([^(]+)\.end\(\)\)/HexStr(\1)/g' $(git grep -l HexStr)` Taken from comment bitcoin#19373 (comment) on bitcoin#19373
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 18, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 19, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 20, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
May 21, 2021
Merge bitcoin#19660, bitcoin#19373, bitcoin#19841, bitcoin#13862, bitcoin#13866, bitcoin#17280, bitcoin#17682 and partial bitcoin#19326, bitcoin#14978: Auxiliary Backports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HexStr can be called with anything that bas
begin()andend()functions, so clean up the redundant calls.(context: I tried to convert
HexStrto use span, but this turns out to be somewhat more involved than I thought, because of the limitation to pre-c++17 Span lacking iterator-based constructor) . This commit is a first step which stands on its own though)