doc: add release note for bitcoin-cli -generate #19357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
reviewed
Jun 23, 2020
| followed by `generatetoaddress`, can generate blocks for command line testing | ||
| purposes. This is a client-side version of the | ||
| [former](https://github.com/bitcoin/bitcoin/issues/14299) `generate` RPC. See | ||
| the help for details. (#19133) |
There was a problem hiding this comment.
This doesn't produce a link (see markdown preview). I think you need to use bitcoin/issues#19133.
There was a problem hiding this comment.
FWIW neither #<issue> or bitcoin/issues#<issue> produces a link in release notes (at least those published on the websites). They're markdown without github extensiosn. I don't think this is a problem though, people can look up the issue number of they want, it doesn't need to be full of links to github.
There was a problem hiding this comment.
I think the goal is so that the verbose paragraphs refer to the list of merged pull requests below (and again those refer to the actual pull requests on github?)
|
ACK 9886c7d |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 27, 2021
9886c7d doc: add release note for bitcoin-cli -generate (Jon Atack) Pull request description: Adds a release note for bitcoin#19133. ACKs for top commit: laanwj: ACK 9886c7d Tree-SHA512: 1354e5db0098447788c9ded6f2cd868fd6ea4a1443c99bec8026881b962c92b7257bfea45757769071605faeb989e9db48eaa2fbe9d273513aa2905ee479a8ec
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 28, 2021
9886c7d doc: add release note for bitcoin-cli -generate (Jon Atack) Pull request description: Adds a release note for bitcoin#19133. ACKs for top commit: laanwj: ACK 9886c7d Tree-SHA512: 1354e5db0098447788c9ded6f2cd868fd6ea4a1443c99bec8026881b962c92b7257bfea45757769071605faeb989e9db48eaa2fbe9d273513aa2905ee479a8ec
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 29, 2021
9886c7d doc: add release note for bitcoin-cli -generate (Jon Atack) Pull request description: Adds a release note for bitcoin#19133. ACKs for top commit: laanwj: ACK 9886c7d Tree-SHA512: 1354e5db0098447788c9ded6f2cd868fd6ea4a1443c99bec8026881b962c92b7257bfea45757769071605faeb989e9db48eaa2fbe9d273513aa2905ee479a8ec
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
9886c7d doc: add release note for bitcoin-cli -generate (Jon Atack) Pull request description: Adds a release note for bitcoin#19133. ACKs for top commit: laanwj: ACK 9886c7d Tree-SHA512: 1354e5db0098447788c9ded6f2cd868fd6ea4a1443c99bec8026881b962c92b7257bfea45757769071605faeb989e9db48eaa2fbe9d273513aa2905ee479a8ec
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
9886c7d doc: add release note for bitcoin-cli -generate (Jon Atack) Pull request description: Adds a release note for bitcoin#19133. ACKs for top commit: laanwj: ACK 9886c7d Tree-SHA512: 1354e5db0098447788c9ded6f2cd868fd6ea4a1443c99bec8026881b962c92b7257bfea45757769071605faeb989e9db48eaa2fbe9d273513aa2905ee479a8ec
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
9886c7d doc: add release note for bitcoin-cli -generate (Jon Atack) Pull request description: Adds a release note for bitcoin#19133. ACKs for top commit: laanwj: ACK 9886c7d Tree-SHA512: 1354e5db0098447788c9ded6f2cd868fd6ea4a1443c99bec8026881b962c92b7257bfea45757769071605faeb989e9db48eaa2fbe9d273513aa2905ee479a8ec
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 27, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19357 | core#19357]] Depends on D9952 Test Plan: Proofreading Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9953
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a release note for #19133.