RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME #19282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Jun 15, 2020
| @@ -252,7 +252,7 @@ static UniValue generatetoaddress(const JSONRPCRequest& request) | |||
| RPCExamples{ | |||
| "\nGenerate 11 blocks to myaddress\n" | |||
| + HelpExampleCli("generatetoaddress", "11 \"myaddress\"") | |||
| + "If you are running the bitcoin core wallet, you can get a new address to send the newly generated bitcoin to with:\n" | |||
| + "If you are using the " PACKAGE_NAME " wallet, you can get a new address to send the newly generated bitcoin to with:\n" | |||
There was a problem hiding this comment.
nit: either remove the colon, or add one at line 253 s/myaddress/myaddress:/
Looking at the other helps like listwallets, generatetodescriptor, etc., no colons seem to be used.
There was a problem hiding this comment.
RPCMan can take care of all formatting needs in the future. Instead of playing formatting ping-pong, I recommend to make progress on #18531
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 2, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19282 | core#19282]] Test Plan: `src/bitcoin-cli help generatetoaddress` Reviewers: #bitcoin_abc, Fabien, deadalnix Reviewed By: #bitcoin_abc, Fabien, deadalnix Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D9615
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.