ci: Move travis workarounds to .travis.yml #19276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e84e89 to
6fbe3b2
Compare
6fbe3b2 to
fa71667
Compare
|
Has anyone an explanation? |
maflcko
commented
Jun 14, 2020
| @@ -33,9 +33,7 @@ if [ -z "$NO_DEPENDS" ]; then | |||
| else | |||
| SHELL_OPTS="CONFIG_SHELL=" | |||
| fi | |||
| # Temporary workaround for https://github.com/bitcoin/bitcoin/issues/16368 | |||
| python3 -c 'import time; [print(".") or time.sleep(500) for _ in range(4)]' & | |||
There was a problem hiding this comment.
I believe the issue was that this print did nothing, because by default flush=False (see https://docs.python.org/3.8/library/functions.html#print ).
Testing locally and on travis x86, it did always happen to print, just not on travis arm.
hebasto
reviewed
Jun 14, 2020
Comment on lines
-24
to
-25
| bash -c "${CI_WAIT}" & # Print dots in case the tests take a long time to run | ||
|
|
There was a problem hiding this comment.
This deletion is also necessary?
There was a problem hiding this comment.
CI_WAIT no longer exists and this should be a no-op
There was a problem hiding this comment.
Yes, CI_WAIT was dropped from the .travis.yml in #18929.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems odd to have travis related workarounds in the general ci config files. Fix that oddity by moving the travis related workarounds to the travis yaml file.
For unexplained reasons, this should also work around and thus close #19171