Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented May 10, 2020

Just how MAKEJOBS is passed down to the functional test test_runner, do the same for the fuzz test_runner.

Also includes a commit to remove unused config files, which have been moved elsewhere.

@fanquake fanquake added the Tests label May 10, 2020
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Remove inconsistency between functional and unit test environments and make it
possible to substitute bitcoin-qt and bitcoin-node in place of bitcoind in
python tests, or to link bitcoind against shared libraries.
@maflcko maflcko changed the title ci: Pass down MAKEJOBS to fuzz test_runner ci: Pass down LD_LIBRARY_PATH and MAKEJOBS to fuzz test_runner May 10, 2020
@maflcko
Copy link
Member Author

maflcko commented May 10, 2020

I've stolen a commit from the conflicting pr, which does the same thing for LD_LIBRARY_PATH to bundle related changes into one pr.

@maflcko maflcko merged commit 4fa3157 into bitcoin:master May 12, 2020
@maflcko maflcko deleted the 2005-fuzzMakejobs branch May 12, 2020 11:48
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 12, 2020
…zz test_runner

cbd6611 Set LD_LIBRARY_PATH consistently in travis tests (Russell Yanofsky)
fa35c34 Remove unused ci configs that have been moved elsewhere (MarcoFalke)
3333cb9 fuzz: Pass down MAKEJOBS to test_runner (MarcoFalke)

Pull request description:

  Just how `MAKEJOBS` is passed down to the functional test `test_runner`, do the same for the fuzz `test_runner`.

  Also includes a commit to remove unused config files, which have been moved elsewhere.

Top commit has no ACKs.

Tree-SHA512: 32557102c9e40599b432aeb004c8427e8fbb07cdf4048050cdc8241d1b029aaad306b1131007eeca8315a4f71c38a7efbb833310e056cd11b835676cd19b8902
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 6, 2020
Summary:
Backport of core [[bitcoin/bitcoin#18929 | PR18929]].

Depends on D8277.

Test Plan:
  ninja bitcoin-fuzzers
  ./test/fuzz/test_runner.py -j 20 <path_to_corpus>

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8278
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants