Skip to content

build: remove BIP70 configure option #19257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

build: remove BIP70 configure option #19257

merged 1 commit into from
Jul 1, 2020

Conversation

fanquake
Copy link
Member

This was left in after #17165, so that anyone who had been compiling
with (already disabled by default) BIP70 would realise that support
had been completely removed in 0.20.0. However we should be able to
remove it for 0.21.0.

@fanquake
build: remove BIP70 configure option
c4ffcf0 
This was left in after bitcoin#17165, so that anyone who had been compiling
with (already disabled by default) BIP70 would realise that support
had been completely removed in 0.20.0. However we should be able to
remove it for 0.21.0.
@Sjors
Copy link
Member

Sjors commented Jun 12, 2020

Given that ./configure doesn't fail for unrecognised options, I have light preference for keeping this error. Though I doubt anyone uses it.

@laanwj
Copy link
Member

laanwj commented Jun 12, 2020 •
edited
Loading

Given that ./configure doesn't fail for unrecognised options, I have light preference for keeping this error. Though I doubt anyone uses it.

I somewhat agree. I think this special case should be removed (why does an unsupported option have a help string?!?), though replaced with a catch-all to reject formerly supported arguments.

Ideally there would a way to get ./configure to reject all unknown options (while still allowing, somehow, to pass configure arguments to subtrees).

@jnewbery
Copy link
Contributor

utACK c4ffcf0

@maflcko
Copy link
Member

maflcko commented Jun 13, 2020

ACK c4ffcf0 with or without the "catch-all reject"

@laanwj
Copy link
Member

laanwj commented Jul 1, 2020

with or without the "catch-all reject"

Handing unrecognized arguments in configure can be left for another PR I guess.

@laanwj laanwj merged commit 9d92ee1 into bitcoin:master Jul 1, 2020
@fanquake fanquake deleted the remove_bip70_configure branch July 2, 2020 00:12
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 8, 2020
@laanwj
Merge bitcoin#19257: build: remove BIP70 configure option
2790fd2 
c4ffcf0 build: remove BIP70 configure option (fanquake)

Pull request description:

  This was left in after bitcoin#17165, so that anyone who had been compiling
  with (already disabled by default) BIP70 would realise that support
  had been completely removed in 0.20.0. However we should be able to
  remove it for 0.21.0.

ACKs for top commit:
  jnewbery:
    utACK c4ffcf0
  MarcoFalke:
    ACK c4ffcf0 with or without the "catch-all reject"

Tree-SHA512: a5dd4231ed97c9dd1984fb90d69a8725df2fdda0b963269b0575601c74528e5d820a4a863c428f8ede86eaae2a1606671fe1fcebdeb96b1023f7a5f899270284
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fanquake @Sjors @laanwj @jnewbery @maflcko