Skip to content

Make SetMiscWarning() accept bilingual_str argument #19233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2020
Merged

Make SetMiscWarning() accept bilingual_str argument #19233

merged 3 commits into from
Jun 10, 2020

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jun 10, 2020

This is one more step for consistent usage of bilingual_str.

No new translation messages are defined.

@hebasto hebasto mentioned this pull request Jun 10, 2020
Closed
maflcko
maflcko reviewed Jun 10, 2020
View reviewed changes
@hebasto
Copy link
Member Author

hebasto commented Jun 10, 2020 •
edited
Loading

Updated 45cb61a -> ddafc58 (pr19233.01 -> pr19233.02, diff):

maflcko
maflcko reviewed Jun 10, 2020
View reviewed changes
@hebasto
Copy link
Member Author

hebasto commented Jun 10, 2020

Updated ddafc58 -> d49612f (pr19233.02 -> pr19233.03, diff):

why change the translation?

@laanwj
Copy link
Member

laanwj commented Jun 10, 2020

Code review ACK d49612f
I'm somewhat surprised that GetWarnings wasn't one of the first things changed to this paradigm.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Jun 10, 2020

tested with

LC_ALL=de_DE.UTF-8 QT_QPA_PLATFORM=minimal BITCOIND=bitcoin-qt ./test/functional/feature_versionbits_warning.py -l DEBUG --tracerpc

failed with

<-25- [0.000599] {"blocks": 578, "currentblockweight": 4000, "currentblocktx": 0, "difficulty": "4.656542373906925E-10", "networkhashps": 12, "pooledtx": 0, "chain": "regtest", "warnings": "Warnung: Unbekannte neue Regeln aktiviert (Versionsbit 27)"}
2020-06-10T13:49:59.737000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/marco/workspace/btc_bitcoin_core/test/functional/test_framework/test_framework.py", line 119, in main
    self.run_test()
  File "./test/functional/feature_versionbits_warning.py", line 98, in run_test
    assert WARN_UNKNOWN_RULES_ACTIVE in node.getmininginfo()["warnings"]
AssertionError

ACK d49612f 🌂

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK d49612f98add29066817b7c808b76c2d728948e5 🌂
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUh4nwv+IFYF1/2XoeTK/sL9efCjqADnR3EFMgDVjfrQwcNWPDfxRE8H4iZ6cX2X
FDTGKNrtTKQmyRaPiYIfDIOkrbeJhOmySwwAw9Xu2VVqG5wzZ514aanawaUVUplg
CZc6yQ5If39j6uLGcdJqgeNd0rxfpsdMiLgPMvJ9Ypj3GN31AvGH1psPZcdUlCwV
uMzQJyrD9Be5OSwT3ysg6pvVEIDWzySzBSyvdECLkDtxeSFWoCYOwSp/42i2rQCt
GkxTwr1fvOAbUbiJSvd0FzgUNszb1wtKujAmDNZUmEjYNYWKAEQYwrgzxKEbuCaL
aONEn/UOm6nwpUm2D+h73zGPk9du1TU7iUbbN/iaJyJToq7i+ZElwaIQXzqXIgwx
TKt/5qq3UKvDOPNXDbrCBjxBUu66AvqktmfnUXUiL9wTSxClii1fHuOrATOnoMMt
1FWTIylffIVsF10GHaUvUNVUN0WaMFxoRmAj6WJIML4cw/DGpgo3mFWIhPNu9s8a
CVh78fr0
=BUAL
-----END PGP SIGNATURE-----

Timestamp of file with hash dc976d1ef749013b37bb9e53e592084eef4fed150188607acf86340ed873f7e0 -

@maflcko maflcko merged commit 371a73e into bitcoin:master Jun 10, 2020
@hebasto hebasto deleted the 200610-bi-warn branch June 10, 2020 15:58
@ryanofsky ryanofsky mentioned this pull request Jun 11, 2020
Merged
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request May 31, 2021
@hebasto @PiRK
Make SetMiscWarning() accept bilingual_str argument
1a00135 
Summary:
> refactor: Make GetWarnings() bilingual_str aware internally
bitcoin/bitcoin@38e33aa

> Make GetWarnings() return bilingual_str
bitcoin/bitcoin@d1ae7c0

> Make SetMiscWarning() accept bilingual_str argument
bitcoin/bitcoin@d49612f

This is a backport of [[bitcoin/bitcoin#19233 | core#19233]]

Test Plan:
`ninja all check-all`

`grep -r SetMiscWarning src/`

Reviewers: #bitcoin_abc, Fabien, majcosta

Reviewed By: #bitcoin_abc, Fabien, majcosta

Subscribers: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9610
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @laanwj @DrahtBot @maflcko @fanquake