rpc: remove deprecated getaddressinfo fields #19200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03d12f2 to
9eccbd2
Compare
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 7, 2020
9eccbd2 to
bc01f7a
Compare
|
utACK bc01f7a |
adamjonas
reviewed
Jun 11, 2020
| @@ -3741,25 +3741,18 @@ UniValue getaddressinfo(const JSONRPCRequest& request) | |||
| {RPCResult::Type::STR_HEX, "pubkey", /* optional */ true, "The hex value of the raw public key for single-key addresses (possibly embedded in P2SH or P2WSH)."}, | |||
| {RPCResult::Type::OBJ, "embedded", /* optional */ true, "Information about the address embedded in P2SH or P2WSH, if relevant and known.", | |||
| { | |||
| {RPCResult::Type::ELISION, "", "Includes all\n" | |||
There was a problem hiding this comment.
Unrelated, but if you are reformatting these lines could you clean up line 1544?
There was a problem hiding this comment.
Good idea. Will touch up in the next PR to not invalidate review.
There was a problem hiding this comment.
There was a problem hiding this comment.
Decided to do it in another PR or code a general solution to line wrapping in the RPC help rather than manual adjustments.
This was referenced Jun 12, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 7, 2020
bc01f7a doc: release note for rpc getaddressinfo removals (Jon Atack) 90e9893 rpc: getaddressinfo RPCResult fixup (Jon Atack) a8507c9 rpc: remove deprecated getaddressinfo `labels: purpose` (Jon Atack) 645a865 rpc: remove deprecated getaddressinfo `label` field (Jon Atack) Pull request description: These were deprecated in bitcoin#17578 and bitcoin#17585, with expected 0.21 removal notified in the 0.20 release notes. ``` - The `getaddressinfo` RPC has had its `label` field deprecated (re-enable for this release using the configuration parameter `-deprecatedrpc=label`). The `labels` field is altered from returning JSON objects to returning a JSON array of label names (re-enable previous behavior for this release using the configuration parameter `-deprecatedrpc=labelspurpose`). Backwards compatibility using the deprecated configuration parameters is expected to be dropped in the 0.21 release. (bitcoin#17585, bitcoin#17578) ``` ACKs for top commit: Sjors: utACK bc01f7a adamjonas: utACK bc01f7a meshcollider: utACK bc01f7a Tree-SHA512: ae1af381e32c4c3bde8b061a56382838513a9a82c88767843cdeae3a2ab8aa7d8c2e66e106d2b31ea07d74bb80c191a2f842c9aaecc7c5438ad9a9bc66d1b251
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 3, 2021
Summary: > rpc: remove deprecated getaddressinfo `label` field > rpc: remove deprecated getaddressinfo `labels: purpose` > rpc: getaddressinfo RPCResult fixup > doc: release note for rpc getaddressinfo removals This is a backport of [[bitcoin/bitcoin#19200 | core#19200]] Depends on D9609 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta, Mengerian Reviewed By: #bitcoin_abc, majcosta, Mengerian Subscribers: Mengerian, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9622
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were deprecated in #17578 and #17585, with expected 0.21 removal notified in the 0.20 release notes.