test: Remove leftover comment in mining_basic #19206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2020 08:10
Can be reviewed with the git options --word-diff-regex=. --ignore-all-space -U0
|
code review ACK fa98e10 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 11, 2020
fa98e10 test: Remove leftover comment in mining_basic (MarcoFalke) faedb50 test: pep-8 mining_basic (MarcoFalke) Pull request description: Remove an accidental leftover comment from bitcoin#19082, which no longer applies and thus might be confusing ACKs for top commit: adamjonas: code review ACK fa98e10 Tree-SHA512: c7f7f8f579b3c6e92f45769be0a7af1a421438a3f5524db5278b2269511a9e0e08f44e3836afb26727644035897ee51ff8296d13ce23030549e7403f57b40e40
|
ACK. Thanks for picking this up, Marco. |
Mitek75
pushed a commit
to Mitek75/bitcoin
that referenced
this pull request
Jun 14, 2020
… mining_basic"" This reverts commit 6fc3a73.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an accidental leftover comment from #19082, which no longer applies and thus might be confusing