refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions #19100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK removing all that copy-paste boilerplate |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced May 29, 2020
promag
reviewed
Jun 1, 2020
ryanofsky
commented
Jun 1, 2020
Comment on lines
-2553
to
-2565
| if (!EnsureWalletIsAvailable(wallet.get(), request.fHelp)) { | ||
| return NullUniValue; | ||
| } |
There was a problem hiding this comment.
Note: PR is just dropping the Ensure check here which has been around since 9508761. It seems like it never did anything because the wallet pointer would never be null, and it was probably added originally as a precaution
…ble functions This simplifies control flow and also helps get rid of the ::vpwallets variable, because EnsureWalletIsAvailable doesn't have access to the request context.
promag
reviewed
Jun 11, 2020
Comment on lines
-2553
to
-2565
| if (!EnsureWalletIsAvailable(wallet.get(), request.fHelp)) { | ||
| return NullUniValue; | ||
| } |
|
ACK f42f5e5 (reviewed code to check that this is a refactor) 💢 Show signature and timestampSignature: Timestamp of file with hash |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 11, 2020
… EnsureWalletIsAvailable functions f42f5e5 refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions (Russell Yanofsky) Pull request description: This simplifies control flow and also helps get rid of the ::vpwallets variable in bitcoin#19101 since EnsureWalletIsAvailable doesn't have access to the request context. ACKs for top commit: MarcoFalke: ACK f42f5e5 (reviewed code to check that this is a refactor) 💢 promag: Tested ACK f42f5e5. Tree-SHA512: eb10685de3db3c1d10c3a797d8da5c8c731e4a8c9024bbb7245929ba767a77a52783a739b8cb1fa7af6fcd233dcf9c8ebbe414eb8b902e2542601aac18625997
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 29, 2021
…ble functions Summary: This simplifies control flow and also helps get rid of the ::vpwallets variable, because EnsureWalletIsAvailable doesn't have access to the request context. This is a backport of [[bitcoin/bitcoin#19100 | core#19100]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D9452
cryptapus
pushed a commit
to cryptapus/bitcoin
that referenced
this pull request
May 3, 2021
Updated RPCs for Bitcoin PRs bitcoin#19100 and bitcoin#19250.
cryptapus
pushed a commit
to cryptapus/bitcoin
that referenced
this pull request
May 3, 2021
Updated RPCs for Bitcoin PRs bitcoin#19100 and bitcoin#19250.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies control flow and also helps get rid of the ::vpwallets variable in #19101 since EnsureWalletIsAvailable doesn't have access to the request context.