rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} #18946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2020 09:53
… of T{}
Optional::emplace() was only added in boost 1.56, see
boostorg/optional@2e583aa
To simply work around bitcoin#18943,
replace it with assignment of T{}
pwallet is never null everywhere where it is dereferenced, so simply replace it with a reference, which can not be null by definition.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
promag
reviewed
May 11, 2020
This was referenced May 11, 2020
|
ACK fa1f840 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 17, 2020
…ith simple assignment of T{}
fa1f840 rpcwallet: Replace pwallet-> with wallet. (MarcoFalke)
fa182a8 rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (MarcoFalke)
Pull request description:
Closes bitcoin#18943
ACKs for top commit:
laanwj:
ACK fa1f840
ryanofsky:
Code review ACK fa1f840 and thanks for using a standalone commit for the fix
promag:
Code review ACK fa1f840.
hebasto:
ACK fa1f840, tested on Linux Mint 19.3.
Tree-SHA512: 0838485d1f93f737ce5bf12740669dcafeebb78dbc3fa15dbcc511edce64bf024f60f0497a04149a1e799d893d57b0c9ffe442020c1b9cfc3c69db731f50e712
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 29, 2021
Summary:
> rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{}
>
> Optional::emplace() was only added in boost 1.56, see
> boostorg/optional@2e583aa
>
> To simply work around bitcoin/bitcoin#18943,
> replace it with assignment of T{}
bitcoin/bitcoin@fa1f840
Backport note: Bitcoin ABC already enforces boost > 1.59, and uses `std::optional` anyway, so this first commit
is included only for future backporting convenience.
----------------------
> rpcwallet: Replace pwallet-> with wallet.
>
> pwallet is never null everywhere where it is dereferenced, so simply
> replace it with a reference, which can not be null by definition.
bitcoin/bitcoin@fa1f840
-----------
This is a backport of Core [[bitcoin/bitcoin#18946 | PR18946]]
Test Plan: `ninja all check-all`
Reviewers: #bitcoin_abc, majcosta
Reviewed By: #bitcoin_abc, majcosta
Differential Revision: https://reviews.bitcoinabc.org/D9112
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18943