Skip to content

Conversation

practicalswift
Copy link
Contributor

Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer.

Closes #18749.

@fanquake fanquake added the Tests label Apr 24, 2020
@practicalswift practicalswift changed the title tests: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer Apr 24, 2020
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK if travis passes

@practicalswift practicalswift force-pushed the remove-EXPECTED_DESERIALIZATION_EXCEPTIONS branch from 36d1698 to 7ea57c9 Compare April 24, 2020 12:44
@practicalswift practicalswift force-pushed the remove-EXPECTED_DESERIALIZATION_EXCEPTIONS branch from 7ea57c9 to fdceb63 Compare April 24, 2020 14:54
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko merged commit 8c0f86f into bitcoin:master Apr 24, 2020
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request May 15, 2020
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 22, 2021
…ocessMessage(...) fuzzer

Summary:
```
The exceptions thrown by the libstdc++ and libc++ standard libraries
seems to differ for iostream errors. libstdc++ will output iostream
error while libc++ will output unspecified iostream_category error. This
means that the expected serialization messages [...] don't always work.
```

Backport of core [[bitcoin/bitcoin#18757 | PR18757]].

Test Plan:
  ninja bitcoin-fuzzers
  ./test/fuzz/test_runner.py <path_to_corpus>

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9013
backpacker69 referenced this pull request in peercoin/peercoin Mar 28, 2021
…ocessMessage(...) fuzzer

Github-Pull: #18757
Rebased-From: fdceb63
@practicalswift practicalswift deleted the remove-EXPECTED_DESERIALIZATION_EXCEPTIONS branch April 10, 2021 19:40
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fuzz: libstdc++ vs libc++ iostream exception messages differ
4 participants