bench: add CAddrMan benchmarks #18754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added benchmarks exercise the public methods Add(), GetAddr(), Select() and Good().
maflcko
approved these changes
Apr 24, 2020
| return; | ||
| } | ||
|
|
||
| FastRandomContext rng(uint256(std::vector<unsigned char>(32, 123))); |
There was a problem hiding this comment.
nit: I think you can just set
Suggested change
| FastRandomContext rng(uint256(std::vector<unsigned char>(32, 123))); | |
| FastRandomContext rng(/* deterministic */ true); |
or is there a reason for the seed?
There was a problem hiding this comment.
Right, /* deterministic */ true would have been better. I will have this in mind and also change this code if I am touching it again.
There is no need for the chosen seed - it only has to be the same every time to reduce noise in performance tests.
Thanks!
|
cc @naumenkogs (you might be interested in this) |
|
utACK a9b9577 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 25, 2020
a9b9577 bench: add CAddrMan benchmarks (Vasil Dimov) Pull request description: The added benchmarks exercise the public methods Add(), GetAddr(), Select() and Good(). ACKs for top commit: naumenkogs: utACK a9b9577 MarcoFalke: ACK a9b9577 Tree-SHA512: af54b2fbd97db34faf4cc6c9bacb20d2c97d0aaddb9cf91b220bc2e09227b55345402ed17e34450745493e3a2b286c176c031cdeb477415570a757cee16b06a8
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 21, 2021
Summary: a9b957740e3490d87e5ce0b7f1b93ba43bb19764 bench: add CAddrMan benchmarks (Vasil Dimov) Pull request description: The added benchmarks exercise the public methods Add(), GetAddr(), Select() and Good(). --- Backport of Core [[bitcoin/bitcoin#18754 | PR18754]] Test Plan: ninja all ./src/bench/bitcoin-bench -filter=AddrMan.* Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8992
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Apr 14, 2021
Summary: a9b957740e3490d87e5ce0b7f1b93ba43bb19764 bench: add CAddrMan benchmarks (Vasil Dimov) Pull request description: The added benchmarks exercise the public methods Add(), GetAddr(), Select() and Good(). --- Backport of Core [[bitcoin/bitcoin#18754 | PR18754]] Test Plan: ninja all ./src/bench/bitcoin-bench -filter=AddrMan.* Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8992
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added benchmarks exercise the public methods Add(), GetAddr(),
Select() and Good().