Skip to content

Conversation

practicalswift
Copy link
Contributor

Add fuzzing harnesses for various classes/functions in util/.

See doc/fuzzing.md for information on how to fuzz Bitcoin Core. Don't forget to contribute any coverage increasing inputs you find to the Bitcoin Core fuzzing corpus repo.

Happy fuzzing :)

#include <cstdint>
#include <vector>

// The fuzzing kitchen sink: Fuzzing harness for functions that need to be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@maflcko
Copy link
Member

maflcko commented Apr 22, 2020

ACK 9014c59

@practicalswift
Copy link
Contributor Author

@MarcoFalke Thanks a lot for the super quick review. I added another commit which adds fuzzing coverage for two functions (JSONRPCTransactionError and RPCErrorFromTransactionError) by re-using the same TransactionError object used for fuzzing TransactionErrorString. Please re-review :)

@practicalswift practicalswift changed the title tests: Add fuzzing harnesses for various classes/functions in util/ test: Add fuzzing harnesses for various classes/functions in util/ Apr 24, 2020
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 24, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor Author

Rebased! :)

@maflcko maflcko merged commit 95a9165 into bitcoin:master Apr 29, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 2, 2020
…functions in util/

32b6b38 tests: Sort fuzzing harnesses (practicalswift)
e1e181f tests: Add fuzzing coverage for JSONRPCTransactionError(...) and RPCErrorFromTransactionError(...) (practicalswift)
103b6ec tests: Add fuzzing coverage for TransactionErrorString(...) (practicalswift)
dde508b tests: Add fuzzing coverage for ParseFixedPoint(...) (practicalswift)
1532259 tests: Add fuzzing coverage for FormatHDKeypath(...) and WriteHDKeypath(...) (practicalswift)
90b635e tests: Add fuzzing coverage for CHECK_NONFATAL(...) (practicalswift)
a4e3d13 tests: Add fuzzing coverage for StringForFeeReason(...) (practicalswift)
a19598c tests: Add fuzzing harness for functions in system.h (ArgsManager) (practicalswift)

Pull request description:

  Add fuzzing harnesses for various classes/functions in `util/`.

  See [`doc/fuzzing.md`](https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md) for information on how to fuzz Bitcoin Core. Don't forget to contribute any coverage increasing inputs you find to the [Bitcoin Core fuzzing corpus repo](https://github.com/bitcoin-core/qa-assets).

  Happy fuzzing :)

Top commit has no ACKs.

Tree-SHA512: d27947220850c2a202c7740f44140c17545f45522596912452ccab0c2f5379abeb07cc769982c7855cb465059425206371a2b75ee1c285b03984161c9619d0b0
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 22, 2021
Summary:
Backport of core [[bitcoin/bitcoin#18736 | PR18736]].

2 commits have been skipped because irrelevant:
 - tests: Add fuzzing coverage for StringForFeeReason(...)
 - tests: Sort fuzzing harnesses

Test Plan:
  ninja bitcoin-fuzzers
  ./test/fuzz/test_runner.py <path_to_corpus>

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9015
@practicalswift practicalswift deleted the fuzzers-2020-04-21 branch April 10, 2021 19:41
kwvg added a commit to kwvg/dash that referenced this pull request Aug 11, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants