-
Notifications
You must be signed in to change notification settings - Fork 37.8k
test: Add fuzzing harnesses for various classes/functions in util/ #18736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#include <cstdint> | ||
#include <vector> | ||
|
||
// The fuzzing kitchen sink: Fuzzing harness for functions that need to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
ACK 9014c59 |
@MarcoFalke Thanks a lot for the super quick review. I added another commit which adds fuzzing coverage for two functions ( |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
66e443e
to
7f2a80d
Compare
Rebased! :) |
…rrorFromTransactionError(...)
7f2a80d
to
e1e181f
Compare
…functions in util/ 32b6b38 tests: Sort fuzzing harnesses (practicalswift) e1e181f tests: Add fuzzing coverage for JSONRPCTransactionError(...) and RPCErrorFromTransactionError(...) (practicalswift) 103b6ec tests: Add fuzzing coverage for TransactionErrorString(...) (practicalswift) dde508b tests: Add fuzzing coverage for ParseFixedPoint(...) (practicalswift) 1532259 tests: Add fuzzing coverage for FormatHDKeypath(...) and WriteHDKeypath(...) (practicalswift) 90b635e tests: Add fuzzing coverage for CHECK_NONFATAL(...) (practicalswift) a4e3d13 tests: Add fuzzing coverage for StringForFeeReason(...) (practicalswift) a19598c tests: Add fuzzing harness for functions in system.h (ArgsManager) (practicalswift) Pull request description: Add fuzzing harnesses for various classes/functions in `util/`. See [`doc/fuzzing.md`](https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md) for information on how to fuzz Bitcoin Core. Don't forget to contribute any coverage increasing inputs you find to the [Bitcoin Core fuzzing corpus repo](https://github.com/bitcoin-core/qa-assets). Happy fuzzing :) Top commit has no ACKs. Tree-SHA512: d27947220850c2a202c7740f44140c17545f45522596912452ccab0c2f5379abeb07cc769982c7855cb465059425206371a2b75ee1c285b03984161c9619d0b0
Summary: Backport of core [[bitcoin/bitcoin#18736 | PR18736]]. 2 commits have been skipped because irrelevant: - tests: Add fuzzing coverage for StringForFeeReason(...) - tests: Sort fuzzing harnesses Test Plan: ninja bitcoin-fuzzers ./test/fuzz/test_runner.py <path_to_corpus> Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9015
Add fuzzing harnesses for various classes/functions in
util/
.See
doc/fuzzing.md
for information on how to fuzz Bitcoin Core. Don't forget to contribute any coverage increasing inputs you find to the Bitcoin Core fuzzing corpus repo.Happy fuzzing :)