test: add coverage for -rpcwallet cli option #18724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Apr 21, 2020
jonatack
commented
Apr 21, 2020
0e64fb6 to
5835c4a
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 21, 2020
|
ACK 5835c4a Passes for me locally. I remember doing a lot of this manually for your PR Review Club session a few weeks ago. Thanks for adding all this as a test! |
5835c4a to
442d025
Compare
|
Thanks @robot-visions for reviewing. I replaced the timeout magic value of 60 with |
and add -getinfo coverage with multiple wallets loaded.
442d025 to
2495110
Compare
|
ACK 2495110 Tests still pass. Thanks for updating! |
|
Thanks for writing tests |
maflcko
reviewed
Apr 24, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 25, 2020
2495110 test: add coverage for -rpcwallet cli option (Jon Atack) Pull request description: The bitcoin-cli `-rpcwallet=` option is an essential RPC/CLI option when more than one wallet is loaded (see `bitcoin-cli -help | grep -A5 rpcwallet` or `src/bitcoin-cli.cpp::L61`) and it currently has no test coverage. It is not only used by users, but also by the test framework and ~10 test files via `get_wallet_rpc()`. This PR adds coverage, while simultaneously improving the `-getinfo` coverage when multiple wallets are loaded. This is similar to the test coverage that would be added in bitcoin#18594. ACKs for top commit: robot-visions: ACK 2495110 Tree-SHA512: caaa8b99fb8fa481ab2c6b2a287ed29720bb4553c3f66657462c44fa2990acaaf36cabeaaf81408678e5fdce4e105d729dd94b5ed8588dd1a6f2cb03fc25acf3
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 9, 2020
and add -getinfo coverage with multiple wallets loaded. Github-Pull: bitcoin#18724 Rebased-From: 2495110
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 13, 2020
and add -getinfo coverage with multiple wallets loaded. Github-Pull: bitcoin#18724 Rebased-From: 2495110
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 14, 2020
and add -getinfo coverage with multiple wallets loaded. Github-Pull: bitcoin#18724 Rebased-From: 2495110
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 20, 2021
Summary: and add -getinfo coverage with multiple wallets loaded. > The bitcoin-cli -rpcwallet= option is an essential RPC/CLI option when more than one wallet is loaded (see bitcoin-cli -help | grep -A5 rpcwallet or src/bitcoin-cli.cpp::L61) and it currently has no test coverage. > > It is not only used by users, but also by the test framework and ~10 test files via get_wallet_rpc(). > > This PR adds coverage, while simultaneously improving the -getinfo coverage when multiple wallets are loaded. This is a backport of Core [[bitcoin/bitcoin#18724 | PR18724]] Test Plan: `./test/functional/test_runner.py interface_bit*` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8975
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitcoin-cli
-rpcwallet=option is an essential RPC/CLI option when more than one wallet is loaded (seebitcoin-cli -help | grep -A5 rpcwalletorsrc/bitcoin-cli.cpp::L61) and it currently has no test coverage.It is not only used by users, but also by the test framework and ~10 test files via
get_wallet_rpc().This PR adds coverage, while simultaneously improving the
-getinfocoverage when multiple wallets are loaded. This is similar to the test coverage that would be added in #18594.