test: display command line options passed to send_cli() in debug log #18712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A good way to test this is to run |
maflcko
reviewed
Apr 20, 2020
11966cd to
65c2024
Compare
and fixup two cli calls from rpc commands to command line options. Co-authored-by: MarcoFalke <falke.marco@gmail.com>
65c2024 to
8f5dc88
Compare
|
ACK 8f5dc88 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 24, 2020
…d_cli() in debug log 8f5dc88 test: display command line options passed to send_cli() in debug log (Jon Atack) Pull request description: as per bitcoin#18691 (comment), and revert two cli calls changed in bitcoin#18691 from rpc commands back to command line options (these were the only occurrences). ACKs for top commit: MarcoFalke: ACK 8f5dc88 Tree-SHA512: fcb3eca00aa4099066028c90d5e50a02e074366e09a17f5f5b937d9f7562dd054ff65681aa0ad4c94f6de1e98b1e2b9ac4cd084ddc297010253989a80483b1b9
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 20, 2021
Summary: Co-authored-by: MarcoFalke <falke.marco@gmail.com> The changes in interface_bitcoin_cli.py were already applied in our codebase. This is a backport of Core [[bitcoin/bitcoin#18712 | PR18712]] Test Plan: Add a failure (`assert False`) in `interface_bitcoin_cli.py` after a call to `send_cli()` Check the presence of the new debug message in the log, just before the failure. Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8963
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #18691 (comment), and revert two cli calls changed in #18691 from rpc commands back to command line options (these were the only occurrences).