appveyor: Remove clcache #18640
Merged
appveyor: Remove clcache #18640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4326fe0 to
fac0c8d
Compare
|
The build https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/32183943 finished in 44 minutes Anything left to do here? |
sipa
reviewed
Apr 15, 2020
| after_build: | ||
| - ps: fsutil behavior set disablelastaccess 1 # Disable Access time feature on Windows (better performance) |
There was a problem hiding this comment.
Removing this line seems unrelated.
There was a problem hiding this comment.
See this build here: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/32194931
So with this line added, it slowed down the build. Or at least didn't speed it up, so I don't feel comfortable keeping it.
Test code should be minimal, easy to read and easy to write. Having a line say "better performance" without any data to back up the claim doesn't help.
c187b5d to
fac0c8d
Compare
|
I am going to go ahead and merge this. If someone finds a way to speed things up, great, we can take them. Though, it doesn't look like clcache speeds things up at all for us. This might be a configuration error or it might be vaporvare, and keeping in the code in the appveyor yaml isn't helping anyone. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 15, 2020
fac0c8d appveyor: Remove clcache (MarcoFalke) Pull request description: The build time without cache seems to be 47 minutes and with cache 46 minutes. Maybe we can save more time by not installing clcache. Top commit has no ACKs. Tree-SHA512: ce503641a465f5e49deb7aa6b566aaab5e567148c001704451891c49ba7ade3219ca788bc0d8e55565febb9aadd579e26894f6c03b99755eb8b5d1498acf4dc9
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jul 10, 2020
Github-Pull: bitcoin#18640 Rebased-From: fac0c8d
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Aug 11, 2020
Github-Pull: bitcoin#18640 Rebased-From: fac0c8d
Merged
maflcko
pushed a commit
that referenced
this pull request
Aug 11, 2020
be95147 Updated appveyor job to checkout a specific vcpkg commit ID. (Aaron Clauson) 1fd9cd2 appveyor: Remove clcache (MarcoFalke) 8c0a959 Remove cached directories and associated script blocks from appveyor CI configuration. (Aaron Clauson) d70f700 lint: fix shellcheck URL in CI install (fanquake) f8f7d91 test: remove Cirrus CI FreeBSD job (fanquake) b7e16a8 Add missing QPainterPath include (Andrew Chow) 30a2814 gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (João Barbosa) 0d87a5b QA: feature_segwit: Check that template "rules" includes "!segwit" as appropriate (Luke Dashjr) bde6a5a Bugfix: Include "csv","!segwit" in "rules" (Luke Dashjr) e422f65 build: Set libevent minimum version to 2.0.21 (Hennadii Stepanov) 0d0dd6a Update with new Windows code signing certificate (Andrew Chow) Pull request description: Backports the following to the 0.19 branch: * #17946 - Fix GBT: Restore "!segwit" and "csv" to "rules" key * #18160 - gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged * #18425 - releases: Update with new Windows code signing certificate * #18676 - build: Check libevent minimum version in configure script * #19097 - qt: Add missing QPainterPath include (as per #19510) * #18640 - appveyor: Remove clcache * #19444 - test: Remove cached directories and associated script blocks from appveyor config * #19612 - lint: fix shellcheck URL in CI install * #18001 - Updated appveyor job to checkout a specific vcpkg commit ID Closes: #19510. ACKs for top commit: jnewbery: ACK be95147 MarcoFalke: cherry-pick ACK be95147 🌎 Tree-SHA512: 2ec7e3ae1da99799ff6f8cfe26095d6885cffe6952b18a7e236dc5e657b3918225c2601b8c8e17cdff5319c40cb0a214d9fad49b0ff2f54af1db7c81d83a1df5
backpacker69
referenced
this pull request
in peercoin/peercoin
Sep 8, 2020
Github-Pull: #18640 Rebased-From: fac0c8d
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Oct 21, 2020
Github-Pull: bitcoin#18640 Rebased-From: fac0c8d
Platinumwrist
referenced
this pull request
in syscoin/syscoin
Oct 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build time without cache seems to be 47 minutes and with cache 46 minutes. Maybe we can save more time by not installing clcache.