gui: use PACKAGE_NAME in exception message #18646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. utACK 1b04302 |
|
utACK 1b04302 |
hebasto
approved these changes
Apr 15, 2020
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 19, 2020
ComputerCraftr
pushed a commit
to ComputerCraftr/bitcoin
that referenced
this pull request
Jun 10, 2020
1b04302 gui: use PACKAGE_NAME in exception message (fanquake) Pull request description: Should address [this comment](bitcoin#18643 (comment)).  Can be triggered with a diff like: ```diff diff --git a/src/qt/modaloverlay.cpp b/src/qt/modaloverlay.cpp index 6243a71..e5d499012 100644 --- a/src/qt/modaloverlay.cpp +++ b/src/qt/modaloverlay.cpp @@ -6,6 +6,7 @@ #include <qt/forms/ui_modaloverlay.h> #include <qt/guiutil.h> +#include <util/check.h> #include <chainparams.h> @@ -179,6 +180,7 @@ void ModalOverlay::showHide(bool hide, bool userRequested) void ModalOverlay::closeClicked() { + CHECK_NONFATAL(false); showHide(true); userClosed = true; } ``` and clicking close in the modal. ```bash EXCEPTION: 18NonFatalCheckError qt/modaloverlay.cpp:183 (closeClicked) Internal bug detected: 'false' You may report this issue here: https://github.com/bitcoin/bitcoin/issues ``` ACKs for top commit: jonasschnelli: Thanks. utACK 1b04302 emilengler: utACK 1b04302 hebasto: ACK 1b04302. Tree-SHA512: 20118269882fbbb5602dafe8101c6ca6c92d7b97efc1ef280a68a83c6a58340018d05f837ecabefee618dc11a62e82828d5ecde4350a71a4c2fd24257b90d45c
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 15, 2021
Summary: This is a backport of Core [[bitcoin/bitcoin#18646 | PR18646]] Test Plan: ``` diff --git a/src/qt/modaloverlay.cpp b/src/qt/modaloverlay.cpp index e5f32fe..c5686cc0d 100644 --- a/src/qt/modaloverlay.cpp +++ b/src/qt/modaloverlay.cpp @@ -7,6 +7,7 @@ #include <chainparams.h> #include <qt/guiutil.h> +#include <util/check.h> #include <QPropertyAnimation> #include <QResizeEvent> @@ -197,6 +198,7 @@ void ModalOverlay::showHide(bool hide, bool userRequested) { } void ModalOverlay::closeClicked() { + CHECK_NONFATAL(false); showHide(true); userClosed = true; } ``` Running `bitcoin-qt` and clicking Hide in the modal causes the exception dialog to appear. Check that it includes "Bitcoin ABC". Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8928
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address this comment.
Can be triggered with a diff like:
and clicking close in the modal.
EXCEPTION: 18NonFatalCheckError qt/modaloverlay.cpp:183 (closeClicked) Internal bug detected: 'false' You may report this issue here: https://github.com/bitcoin/bitcoin/issues