test: Add mempool_updatefromblock.py #18485
Conversation
|
Concept ACK. I don't see any reason not to accept this test as is; but it could be nice to:
|
7ed5558 to
cfaa79b
Compare
|
Updated 7ed5558 -> cfaa79b (pr18485.01 -> pr18485.02, diff).
Done.
Done. |
|
Looks great :) |
cfaa79b to
b9156fd
Compare
|
Updated cfaa79b -> b9156fd (pr18485.02 -> pr18485.03, diff):
|
| """Test mempool descendants/ancestors information update. | ||
|
|
||
| Test mempool update of transaction descendants/ancestors information (count, size) | ||
| when transactions have been re-added from a disconnected block to the mempool. |
There was a problem hiding this comment.
Maybe hints directly to UpdateTransactionsFromBlock
There was a problem hiding this comment.
Maybe hints directly to
UpdateTransactionsFromBlock
This could be more appropriate for unit tests rather for functional ones, no?
There was a problem hiding this comment.
I'm don't have a strong opinon, but sometimes for newcomers is great to lead them directly to what part of the codebase is tested.
| def skip_test_if_missing_module(self): | ||
| self.skip_if_no_wallet() | ||
|
|
||
| def transaction_graph_test(self, size, n_tx_to_mine=None, start_input_txid='', end_address='', fee=Decimal(0.00100000)): |
There was a problem hiding this comment.
How people should use start_input_txid and end_address ? Do you envision having different helpers each with a specific topology and being able to connect them to test different mempool entry points ? Like a N-fan-out connected to a linear chain ?
There was a problem hiding this comment.
Do you envision having different helpers each with a specific topology and being able to connect them to test different mempool entry points ? Like a N-fan-out connected to a linear chain ?
You read my mind :)
b9156fd to
8098dea
Compare
|
Updated b9156fd -> 8098dea (pr18485.03 -> pr18485.04, diff):
|
|
ACK 8098dea |
8098dea test: Add mempool_updatefromblock.py (Hennadii Stepanov) Pull request description: This PR adds a new test for mempool update of transaction descendants/ancestors information (count, size) when transactions have been re-added from a disconnected block to the mempool. It could be helpful for working on PRs like bitcoin#17925, bitcoin#18191. ACKs for top commit: ariard: ACK 8098dea Tree-SHA512: 7e808fa8df8d7d7a7dbdc3f79361049b49c7bce9b58fd5539b28c9636bedac747695537e500d7ed68dc8bdb80167ad3f1c01086f7551691405d2ba2e38ef1d06
Summary: This PR adds a new test for mempool update of transaction descendants/ancestors information (count, size) when transactions have been re-added from a disconnected block to the mempool. This is a backport of Core [[bitcoin/bitcoin#18485 | PR18485]] Note: on line 110, 'vsize' had to be replaced by 'size' to make the test work for ABC Test Plan: `test/functional/test_runner.py mempool_upd*` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D9042
This PR adds a new test for mempool update of transaction descendants/ancestors information (count, size) when transactions have been re-added from a disconnected block to the mempool.
It could be helpful for working on PRs like #17925, #18191.