Skip to content

ci: Use Homebrew addon on native macOS #18438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2020
Merged

ci: Use Homebrew addon on native macOS #18438

merged 2 commits into from
Mar 26, 2020

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 26, 2020 •
edited
Loading

Recently almost every macOS image update on Travis breaks our builds:

This PR:

  • fixes the error caused by the recent update from 10.14.4 (18E226) to 10.14.6 (18G3020) on March 25
  • leverages Homebrew addon to install packages

Homebrew is not told to install automake and pkg-config packages, as the docs states that they are pre-installed:

  • automake 1.16.1
  • pkg-config 0.29.2

@fanquake fanquake added the Tests label Mar 26, 2020
@hebasto hebasto mentioned this pull request Mar 26, 2020
Closed
@hebasto hebasto changed the title [WIP] ci: Use Homebrew addon on native macOS ci: Use Homebrew addon on native macOS Mar 26, 2020
maflcko
maflcko reviewed Mar 26, 2020
View reviewed changes
@hebasto hebasto force-pushed the 20200326-brew-addon branch from ae9b1e2 to 25c8b73 Compare March 26, 2020 12:58
@hebasto
Copy link
Member Author

hebasto commented Mar 26, 2020

Updated ae9b1e2 -> 25c8b73 (pr18438.01 -> pr18438.02, diff):

@fanquake
Copy link
Member

Concept ACK. Thanks for following up with this.

@hebasto hebasto mentioned this pull request Mar 26, 2020
Merged
@maflcko maflcko merged commit f3a91ab into bitcoin:master Mar 26, 2020
@maflcko
Copy link
Member

maflcko commented Mar 26, 2020

Seems to pick up everything correctly (wallet, ccache, qt):

Options used to compile and link:

  with wallet   = yes

  with gui / qt = yes

    with qr     = yes

  with zmq      = yes

  with test     = yes

    with prop   = no

    with fuzz   = no

  with bench    = yes

  with upnp     = yes

  use asm       = yes

  sanitizers    = 

  debug enabled = no

  gprof enabled = no

  werror        = yes

  target os     = darwin

  build os      = darwin

  CC            = /usr/local/bin/ccache gcc

  CFLAGS        = -g -O2

  CPPFLAGS      =   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -I/usr/local/opt/berkeley-db@4/include -DMAC_OSX -DOBJC_OLD_DISPATCH_PROTOTYPES=0

  CXX           = /usr/local/bin/ccache g++ -std=c++11

  CXXFLAGS      =   -Wstack-protector -fstack-protector-all  -Wall -Wextra -Wformat -Wvla -Wswitch -Wformat-security -Wthread-safety-analysis -Wrange-loop-analysis -Wredundant-decls -Wunused-variable -Wdate-time  -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register -Wno-implicit-fallthrough  -Werror=vla -Werror=switch -Werror=thread-safety-analysis -Werror=unused-variable -Werror=date-time -Werror=return-type  -g -O2 -fvisibility=hidden

  LDFLAGS       = -pthread  -Wl,-bind_at_load   -Wl,-headerpad_max_install_names -Wl,-dead_strip -Wl,-dead_strip_dylibs

  ARFLAGS       = cr

@hebasto hebasto deleted the 20200326-brew-addon branch March 26, 2020 13:19
@hebasto hebasto mentioned this pull request Mar 28, 2020
Merged
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
@hebasto hebasto mentioned this pull request Jul 11, 2020
Merged
maflcko pushed a commit that referenced this pull request Jul 14, 2020
Merge #19495: ci: Disable macOS functional tests on forked repos to a…
90b5fc9 
…void timeouts

60824b3 ci: Fix configure options for macOS builds (Hennadii Stepanov)
687939e ci: Drop Homebrew caching while using Homebrew addon on Travis (Hennadii Stepanov)
557d3f1 ci: Do not activate Travis ccache caching strategy (Hennadii Stepanov)
2d74742 ci: Disable functional tests on forked repos to avoid timeouts for macOS (Hennadii Stepanov)

Pull request description:

  See: bitcoin-core/gui#5 (comment)

  Additionally, this PR:
  - updates macOS image to the recent 10.15.5 version
  - drops Homebrew caching as the Travis Homebrew addon have been used since #18438

  My forked repo build: https://travis-ci.org/github/hebasto/bitcoin/jobs/707200431

Top commit has no ACKs.

Tree-SHA512: 398e935f965a04babeb10e7b26d2341562f21a1ef671c2e7cc97c9ec79d5c31643f81ca18561ab7714b5c52e19df2e4bffe4223eadbab984daa9418ffbf8c2a8
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 14, 2020
Merge bitcoin#19495: ci: Disable macOS functional tests on forked rep…
0842b31 
…os to avoid timeouts

60824b3 ci: Fix configure options for macOS builds (Hennadii Stepanov)
687939e ci: Drop Homebrew caching while using Homebrew addon on Travis (Hennadii Stepanov)
557d3f1 ci: Do not activate Travis ccache caching strategy (Hennadii Stepanov)
2d74742 ci: Disable functional tests on forked repos to avoid timeouts for macOS (Hennadii Stepanov)

Pull request description:

  See: bitcoin-core/gui#5 (comment)

  Additionally, this PR:
  - updates macOS image to the recent 10.15.5 version
  - drops Homebrew caching as the Travis Homebrew addon have been used since bitcoin#18438

  My forked repo build: https://travis-ci.org/github/hebasto/bitcoin/jobs/707200431

Top commit has no ACKs.

Tree-SHA512: 398e935f965a04babeb10e7b26d2341562f21a1ef671c2e7cc97c9ec79d5c31643f81ca18561ab7714b5c52e19df2e4bffe4223eadbab984daa9418ffbf8c2a8
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @fanquake @maflcko