[consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig #18422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edc7c89 to
10144d3
Compare
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
…lChecksig This is in preparation for adding different signature verification rules, specifically tapscript (BIP 342), which interprets opcode 0xac and 0xad as Schnorr signature verifications.
a828331 to
14e8cf9
Compare
This was referenced Mar 25, 2020
|
ACK 14e8cf9, verified move-only. |
|
ACK 14e8cf9, reviewed with "git show 14e8cf9 --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space -W" 👆 Show signature and timestampSignature: Timestamp of file with hash |
|
Code-review ACK 14e8cf9, verified that it's move-only. |
|
code review ACK 14e8cf9, verified move-only |
jonatack
reviewed
Apr 1, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 13, 2020
…valScript code to EvalChecksig 14e8cf9 [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig (Pieter Wuille) Pull request description: This is another small refactor pulled out of the Schnorr/Taproot PR bitcoin#17977. This is in preparation for adding different signature verification rules, specifically tapscript (BIP 342), which interprets opcode 0xac and 0xad as Schnorr signature verifications. ACKs for top commit: sipa: ACK 14e8cf9, verified move-only. MarcoFalke: ACK 14e8cf9, reviewed with "git show 14e8cf9 --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space -W" 👆 fjahr: Code-review ACK 14e8cf9, verified that it's move-only. instagibbs: code review ACK bitcoin@14e8cf9, verified move-only theStack: Code-Review ACK bitcoin@14e8cf9 jonatack: ACK 14e8cf9 Tree-SHA512: af2efce9ae39d5ec01db5b9ef0ff383fe252ef5f33b3483927308ae17d91a619266cb45951f32ea1ce54807a4c0f052bcdefb47e244465d3a726393221c227b1
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 15, 2021
…lChecksig Summary: PR description: > This is in preparation for adding different signature verification rules, > specifically tapscript (BIP 342), which interprets opcode 0xac and 0xad > as Schnorr signature verifications. The rationale for backporting this PR into ABC is that extracting a small piece of a huge function into its own function seems positive in itself, even if we don't plan to do the next steps described in the PR discussion. This is a backport of Core [[bitcoin/bitcoin#18422 | PR18422]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8917
PhotoshiNakamoto
added a commit
to PhotonicBitcoin/pBTC-core
that referenced
this pull request
Dec 11, 2021
…lChecksig Bitcoin Core PR:bitcoin/bitcoin#18422 Pull request description: This is another small refactor pulled out of the Schnorr/Taproot PR bitcoin/bitcoin#17977. This is in preparation for adding different signature verification rules, specifically tapscript (BIP 342), which interprets opcode 0xac and 0xad as Schnorr signature verifications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another small refactor pulled out of the Schnorr/Taproot PR #17977.
This is in preparation for adding different signature verification rules,
specifically tapscript (BIP 342), which interprets opcode 0xac and 0xad
as Schnorr signature verifications.