build: Remove Boost Chrono #18264
Merged
build: Remove Boost Chrono #18264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 5, 2020
|
Concept ACK |
2 similar comments
|
Concept ACK |
|
Concept ACK |
1d860a5 to
b79bddc
Compare
b79bddc to
ad34590
Compare
maflcko
reviewed
Mar 7, 2020
| @@ -22,7 +22,7 @@ $(package)_config_opts_armv7a_android=address-model=32 | |||
| $(package)_toolset_$(host_os)=gcc | |||
| $(package)_archiver_$(host_os)=$($(package)_ar) | |||
| $(package)_toolset_darwin=clang-darwin | |||
| $(package)_config_libraries=chrono,filesystem,system,thread,test | |||
| $(package)_config_libraries=filesystem,system,thread,test | |||
There was a problem hiding this comment.
We also/still depend on boost datetime, but it seems this one is a dependency of boost thread, so implicitly included here?
See also the apt command that installs datetime as a dependency of thread:
# apt install libboost-thread-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
libboost-atomic1.71-dev libboost-atomic1.71.0 libboost-chrono1.71-dev libboost-chrono1.71.0
libboost-date-time1.71-dev libboost-date-time1.71.0 libboost-serialization1.71-dev libboost-serialization1.71.0
libboost-thread1.71-dev libboost-thread1.71.0
There was a problem hiding this comment.
Perhaps, but I think we should only declare the libraries we explicitly need (just in case the dependency edges get pruned in the future).
Also, according to the docs for our version of Boost.Thread
Boost.Chrono: This dependency is optional (see below how to configure) and you will need to link with the library if you use some of the time related interfaces.
|
ACK ad34590 |
Gitian builds
|
|
ACK ad34590 |
|
ACK ad34590 Thanks for doing this excellent cleanup work. Great feeling seeing Boost get purged. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 11, 2020
ad34590 doc: remove Boost Chrono from install docs (fanquake) e21fa54 test: remove Boost Chrono installation from CI (fanquake) bd37f2b build: remove Boost Chrono detection from build system (fanquake) 1d0a87e build: remove chrono package from depends Boost (fanquake) Pull request description: We no longer use Boost Chrono. ACKs for top commit: practicalswift: ACK ad34590 MarcoFalke: ACK ad34590 kallewoof: ACK ad34590 Tree-SHA512: d987ab5461c76c982318c65ec8d625094356716b79fd3a462beea75f07db0f82608ace13ec4c4b0233f352508715a4505ac2b4ed1c1e9d9d78f0da936b80f0f3
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 23, 2020
Summary: ``` We no longer use Boost Chrono. ``` Backport of core [[bitcoin/bitcoin#18264 | PR18264]]. Test Plan: ninja all check-all Run the Gitian builds Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7520
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
ad34590 doc: remove Boost Chrono from install docs (fanquake) e21fa54 test: remove Boost Chrono installation from CI (fanquake) bd37f2b build: remove Boost Chrono detection from build system (fanquake) 1d0a87e build: remove chrono package from depends Boost (fanquake) Pull request description: We no longer use Boost Chrono. ACKs for top commit: practicalswift: ACK ad34590 MarcoFalke: ACK ad34590 kallewoof: ACK ad34590 Tree-SHA512: d987ab5461c76c982318c65ec8d625094356716b79fd3a462beea75f07db0f82608ace13ec4c4b0233f352508715a4505ac2b4ed1c1e9d9d78f0da936b80f0f3
This was referenced Sep 9, 2021
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 6, 2021
ad34590 doc: remove Boost Chrono from install docs (fanquake) e21fa54 test: remove Boost Chrono installation from CI (fanquake) bd37f2b build: remove Boost Chrono detection from build system (fanquake) 1d0a87e build: remove chrono package from depends Boost (fanquake) Pull request description: We no longer use Boost Chrono. ACKs for top commit: practicalswift: ACK ad34590 MarcoFalke: ACK ad34590 kallewoof: ACK ad34590 Tree-SHA512: d987ab5461c76c982318c65ec8d625094356716b79fd3a462beea75f07db0f82608ace13ec4c4b0233f352508715a4505ac2b4ed1c1e9d9d78f0da936b80f0f3 # Conflicts: # build_msvc/bitcoin_config.h # ci/test/00_setup_env_native_asan.sh # ci/test/00_setup_env_native_fuzz.sh # ci/test/00_setup_env_native_fuzz_with_valgrind.sh # ci/test/00_setup_env_native_tsan.sh # ci/test/00_setup_env_native_valgrind.sh # depends/packages/boost.mk # doc/build-unix.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use Boost Chrono.