wip: gui: Refactor to drop client and wallet models setters #18239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c3044a to
776d78f
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 2, 2020
776d78f to
9a50cbf
Compare
7692fee to
2f6dd72
Compare
This was referenced Mar 2, 2020
|
Concept ACK on including models in class invariants where appropriate. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
This is based on a PR that has since been closed (#18064), itself hasn't seen any review and currently needs a rebase. If it's still relevant them I'm going to suggest re-opening it in https://github.com/bitcoin-core/gui. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the code simpler as the client and wallet models are set in the constructor and are constant.
Based on #18064, only bbb33d6.
This does't change behavior.