Skip to content

Conversation

promag
Copy link
Contributor

@promag promag commented Nov 26, 2019

These aren't dialogs.

@promag
Copy link
Contributor Author

promag commented Nov 26, 2019

Let me know if I should include script-diff to rename classes and files.

@fanquake fanquake added the GUI label Nov 26, 2019
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 26, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto
Copy link
Member

hebasto commented Nov 27, 2019

Concept ACK.

Let me know if I should include script-diff to rename classes and files.

I think so.

@hebasto
Copy link
Member

hebasto commented Nov 27, 2019

This PR also requires:

  • corresponding changes in forms/*.ui files
  • dropping QDialog slots and signals.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

@fanquake
Copy link
Member

fanquake commented Jul 9, 2020

This has a concept ACK, but looks like it may need additional (qt only) changes, conversion to a scripted diff where appropriate and in any case needs a rebase. I'm going to suggest re-opening this in https://github.com/bitcoin-core/gui.

@fanquake fanquake closed this Jul 9, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants