test: Disable mockforward scheduler unit test for now #18211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
This is still failing on the Win64 and Linux x86_64 (no wallet) jobs: test/scheduler_tests.cpp(157): Entering test case "mockforward"
test/scheduler_tests.cpp(187): error: in "scheduler_tests/mockforward": check num_tasks == 1ul has failed [3 != 1]
test/scheduler_tests.cpp(190): error: in "scheduler_tests/mockforward": check counter == 2 has failed [0 != 2]
test/scheduler_tests.cpp(196): error: in "scheduler_tests/mockforward": check delta > 2*60 && delta < 3*60 has failed
test/scheduler_tests.cpp(157): Leaving test case "mockforward"; testing time: 7640us |
fa02a3c to
fab9336
Compare
6dc8f53 to
3164f16
Compare
laanwj
reviewed
Feb 26, 2020
src/util/time.cpp
Outdated
| #include <tinyformat.h> | ||
|
|
||
| void SleepFor(const std::chrono::microseconds& n) { std::this_thread::sleep_for(n); } |
There was a problem hiding this comment.
It looks like this newly added function is not used in this PR.
3164f16 to
0c46a7e
Compare
0c46a7e to
af57e7d
Compare
af57e7d to
fab2527
Compare
|
ACK fab2527 |
|
Looks like this merge has fixed the constant fails on https://bitcoinbuilds.org |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 27, 2020
…r now fab2527 test: Disable mockforward scheduler unit test for now (MarcoFalke) Pull request description: This should be a workaround to fix bitcoin#18174 in the short run and buy us more time to investigate the issue while ci runs are green again 🙏 ACKs for top commit: fanquake: ACK fab2527 - be good to get Travis back. laanwj: ACK fab2527 Tree-SHA512: 027e86b3dfec203a464e5bf528e9933c208c36633c2d4bfcdbc10da1799637a5d6ea0a63af33a4174fb1ad7115df631a4cb838f56e31f4cbd15498e1e9fdf9cc
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…r now fab2527 test: Disable mockforward scheduler unit test for now (MarcoFalke) Pull request description: This should be a workaround to fix bitcoin#18174 in the short run and buy us more time to investigate the issue while ci runs are green again 🙏 ACKs for top commit: fanquake: ACK fab2527 - be good to get Travis back. laanwj: ACK fab2527 Tree-SHA512: 027e86b3dfec203a464e5bf528e9933c208c36633c2d4bfcdbc10da1799637a5d6ea0a63af33a4174fb1ad7115df631a4cb838f56e31f4cbd15498e1e9fdf9cc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a workaround to fix #18174 in the short run and buy us more time to investigate the issue while ci runs are green again 🙏