build: Skip i686 build by default in guix and gitian #18104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2020 13:22
win32 is no longer mentioned in doc/build-windows.md
fa0902e to
fae9084
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Code review ACK fae9084 |
|
ACK fae9084 -- patch looks correct |
|
bitcoin/contrib/guix/manifest.scm Line 150 in 4c25787 My bad I didn't see "i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate HOSTS." ACK fae9084 patch looks correct |
fanquake
added a commit
that referenced
this pull request
Feb 11, 2020
fae9084 build: Skip i686 build by default in guix and gitian (MarcoFalke) fa55a25 depends: Remove reference to win32 (MarcoFalke) Pull request description: Closes #17504 Now that we no longer provide downloads for i686 on our website (https://bitcoincore.org/en/download/), there is no need to build them by default. i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate `HOSTS`. ACKs for top commit: practicalswift: ACK fae9084 -- patch looks correct dongcarl: ACK fae9084 patch looks correct laanwj: Code review ACK fae9084 hebasto: ACK fae9084, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: b000c19a2cd2a596a52028fa298c4022c24cfdfc1bdb3795a90916d0a00a32e4dd22278db93790b6a11724e08ea8451f4f05c77bc40d1664518e11a8c82d6e29
Gitian builds
|
|
@MarcoFalke I came across this PR. I notice there's still references to i686 in gitian-linux descriptor. https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml#L103 Should they be removed as well? |
From the OP:
|
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 10, 2020
laanwj
added a commit
to bitcoin-dot-org/Bitcoin.org
that referenced
this pull request
Jun 3, 2020
The i686 build was removed in bitcoin/bitcoin#18104. The ARM 32-bit build is still there so leaving that alone. Tree-SHA512: cc0082574e3331fa3a8950f1bff3f80981a0d5f5c59f127c54464c4e1d74b0b5e26c5e59795ba208f9b79599c302d1d9ea36298809aecbc3ce77262e173223e6
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 9, 2020
…guix and gitian" This partially reverts commit fae9084.
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 20, 2020
Summary: Backport of core [[bitcoin/bitcoin#18104 | PR18104]]. From the PR conversation, it is made clear that nobody really uses the shipped binary for 32 bits linux. We can safely stop distributing it as part of our release process, but still make it possible to build from source if desired. The build is now tested on CI to prevent from regression. Test Plan: Run the Gitian Linux build. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7229
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Oct 10, 2021
…guix and gitian" This partially reverts commit fae9084.
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Oct 23, 2021
…x and gitian fae9084 build: Skip i686 build by default in guix and gitian (MarcoFalke) fa55a25 depends: Remove reference to win32 (MarcoFalke) Pull request description: Closes bitcoin#17504 Now that we no longer provide downloads for i686 on our website (https://bitcoincore.org/en/download/), there is no need to build them by default. i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate `HOSTS`. ACKs for top commit: practicalswift: ACK fae9084 -- patch looks correct dongcarl: ACK fae9084 patch looks correct laanwj: Code review ACK fae9084 hebasto: ACK fae9084, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: b000c19a2cd2a596a52028fa298c4022c24cfdfc1bdb3795a90916d0a00a32e4dd22278db93790b6a11724e08ea8451f4f05c77bc40d1664518e11a8c82d6e29
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Nov 9, 2021
…guix and gitian" This partially reverts commit fae9084.
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Dec 4, 2021
…x and gitian fae9084 build: Skip i686 build by default in guix and gitian (MarcoFalke) fa55a25 depends: Remove reference to win32 (MarcoFalke) Pull request description: Closes bitcoin#17504 Now that we no longer provide downloads for i686 on our website (https://bitcoincore.org/en/download/), there is no need to build them by default. i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate `HOSTS`. ACKs for top commit: practicalswift: ACK fae9084 -- patch looks correct dongcarl: ACK fae9084 patch looks correct laanwj: Code review ACK fae9084 hebasto: ACK fae9084, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: b000c19a2cd2a596a52028fa298c4022c24cfdfc1bdb3795a90916d0a00a32e4dd22278db93790b6a11724e08ea8451f4f05c77bc40d1664518e11a8c82d6e29
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Dec 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17504
Now that we no longer provide downloads for i686 on our website (https://bitcoincore.org/en/download/), there is no need to build them by default.
i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate
HOSTS.