refactor: Add ChainClient setMockTime, getWallets methods #17999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-run ci |
promag
reviewed
Jan 27, 2020
maflcko
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
ACK 06edeb4 🚻
Show signature and timestamp
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK 06edeb442971747634d1558130d15e6227325422 🚻
-----BEGIN PGP SIGNATURE-----
iQGyBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUhEFQvzBP27AqgANDYm0anOBCrcFhiEuALQa0nLCp7dkxK34mOqJEWsfzYBjKL8
kdPgbcyOMx9cc0N1YzQJuVUgFsDEzQjv4+SSogMmec00FEIUPl6rJpVMnmeMbsju
+5nmilRKRgZ0TR1Z2dAebe84Cm8go5Il6Il1vI0WcsIE4RzrNVMFAqaVAI/RV+4g
EpOzYCwzEgXMGWw4nixku/hrIVRbAlOTsKrOncYmp10/BtDvT4EhJq7D1w1q67KV
HDgd5PVa8geRmy7DTEvEjpQEYnL2qBR2yr1WtMwzxWBSGrwqSLCfl7RyQuWgX/2x
oMnQzoCszSO9gQM1X7BIag8io0H+hrTgo4OTkWmKxwJHuUX3A8JXTksAPyvw5CSR
CM2bxOZUu6hmdrTCrMWHZTbuexn2AQsEFicIWzlP3Kbi/FQXSC7dmx013KHUSmEj
K1Fg9FZCBvCJq6nO7Eg4MK5qhYDFzWmTkxPWa10zVNc3/Cto4AWPIJnl9AjjkX8o
u+ofy1Y=
=OnjJ
-----END PGP SIGNATURE-----
Timestamp of file with hash 7dc65ddc41d7a97c1cc5b926e0f20c04316b6c5b18b17537c4fc59c620d2d263 -
Needed to set mock times, and get wallet interface pointers correctly when wallet code is running in a different process from node code.
Also clean up forward other forward declarations in interfaces/wallet.h with !sort Original motivation for this change was to fix a circular dependencies lint error: "interfaces/chain.h -> interfaces/wallet.h -> psbt -> node/transaction -> node/context -> interfaces/chain.h" from an earlier commit in this PR adding a "interfaces/chain.h -> interfaces/wallet.h" include. Now, the wallet include is no longer added, but it is still good to clean up the psbt include for efficiency, and to sort the forward declarations.
06edeb4 to
3ce16ad
Compare
ryanofsky
commented
Feb 25, 2020
There was a problem hiding this comment.
Rebased 06edeb4 -> 3ce16ad (pr/ipc-clients.1 -> pr/ipc-clients.2, compare) due to conflict with #18037 and removed extraneous include and method definition.
promag
reviewed
Feb 25, 2020
|
re-ACK 3ce16ad 🔙 Show signature and timestampSignature: Timestamp of file with hash |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 13, 2020
…s methods 3ce16ad refactor: Use psbt forward declaration (Russell Yanofsky) 1dde238 Add ChainClient setMockTime, getWallets methods (Russell Yanofsky) Pull request description: This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10). These changes are needed to set mock times, and get wallet interface pointers correctly when wallet code is running in a different process from node code in bitcoin#10102 ACKs for top commit: MarcoFalke: re-ACK 3ce16ad 🔙 promag: Code review ACK 3ce16ad. Tree-SHA512: 6c093bfcd68adf5858a1aade4361cdb7fb015496673504ac7a93d0bd2595215047184551d6fd526baa27782331cd2819ce45c4cf923b205ce93ac29e485b5dd8
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 16, 2020
Summary: Needed to set mock times, and get wallet interface pointers correctly when wallet code is running in a different process from node code. --- bitcoin/bitcoin@1dde238 Partial backport of Core [[bitcoin/bitcoin#17999 | PR17999]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D6995
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 16, 2020
Summary: Also clean up forward other forward declarations in interfaces/wallet.h with !sort Original motivation for this change was to fix a circular dependencies lint error: "interfaces/chain.h -> interfaces/wallet.h -> psbt -> node/transaction -> node/context -> interfaces/chain.h" from an earlier commit in this PR adding a "interfaces/chain.h -> interfaces/wallet.h" include. Now, the wallet include is no longer added, but it is still good to clean up the psbt include for efficiency, and to sort the forward declarations. --- Depends on D6995 Backport of Core [[bitcoin/bitcoin#17999 | PR17999]] part [2/2] : bitcoin/bitcoin@3ce16ad Test Plan: ninja all check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7962
PhotoshiNakamoto
added a commit
to PhotonicBitcoin/pBTC-core
that referenced
this pull request
Dec 11, 2021
Bitcoin Core PR:bitcoin/bitcoin#17999 Pull request description: This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10). These changes are needed to set mock times, and get wallet interface pointers correctly when wallet code is running in a different process from node code in bitcoin/bitcoin#10102
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the process separation project.
These changes are needed to set mock times, and get wallet interface pointers correctly when
wallet code is running in a different process from node code in #10102