gui: Remove WalletView and BitcoinGUI circular dependency #17937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac36752 to
ba15dae
Compare
ba15dae to
72b5a23
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK. |
hebasto
requested changes
Jan 16, 2020
|
Concept ACK |
72b5a23 to
33727e0
Compare
|
w.r.t. #17500 (comment) It seems a bit of formalization could be helpful for our community. How about: Qt Slots and Signals |
|
@hebasto looks good! |
This was referenced Jan 19, 2020
33727e0 to
cb8a86d
Compare
|
Rebased and reverted to previous version since #17965 was merged. |
|
Appveyor status is wrong, it actually passed. |
jonasschnelli
added a commit
that referenced
this pull request
Feb 1, 2020
cb8a86d gui: Remove WalletView and BitcoinGUI circular dependency (João Barbosa) ac3d107 gui: Add transactionClicked and coinsSent signals to WalletView (João Barbosa) Pull request description: Essentially moves the code in `WalletView::setBitcoinGUI` to the only caller. Two new signals are added beforehand in the first commit so that the connections in `WalletFrame` are all from the wallet view. ACKs for top commit: hebasto: ACK cb8a86d, tested on Linux Mint 19.3. jonasschnelli: utACK cb8a86d Tree-SHA512: 250316cd3689e51c8cded9ccd75963c836dcafa6db25d684f2aa691dea9738895f9140793e0f925784909e39f8257f7e1c7d611e8bd6d6634e1a50333f4ddb1e
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 1, 2020
…ependency cb8a86d gui: Remove WalletView and BitcoinGUI circular dependency (João Barbosa) ac3d107 gui: Add transactionClicked and coinsSent signals to WalletView (João Barbosa) Pull request description: Essentially moves the code in `WalletView::setBitcoinGUI` to the only caller. Two new signals are added beforehand in the first commit so that the connections in `WalletFrame` are all from the wallet view. ACKs for top commit: hebasto: ACK cb8a86d, tested on Linux Mint 19.3. jonasschnelli: utACK cb8a86d Tree-SHA512: 250316cd3689e51c8cded9ccd75963c836dcafa6db25d684f2aa691dea9738895f9140793e0f925784909e39f8257f7e1c7d611e8bd6d6634e1a50333f4ddb1e
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Feb 3, 2020
Fix intro dialog labels when the prune button is toggled (bitcoin#17453) Rename debug window (bitcoin#17096) Add close window shortcut (bitcoin#15768) Add privacy to the Overview page (bitcoin#16432) Remove WalletView and BitcoinGUI circular dependency (bitcoin#17937) Force set nPruneSize in QSettings after the intro dialog (bitcoin#17696)
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…ependency cb8a86d gui: Remove WalletView and BitcoinGUI circular dependency (João Barbosa) ac3d107 gui: Add transactionClicked and coinsSent signals to WalletView (João Barbosa) Pull request description: Essentially moves the code in `WalletView::setBitcoinGUI` to the only caller. Two new signals are added beforehand in the first commit so that the connections in `WalletFrame` are all from the wallet view. ACKs for top commit: hebasto: ACK cb8a86d, tested on Linux Mint 19.3. jonasschnelli: utACK cb8a86d Tree-SHA512: 250316cd3689e51c8cded9ccd75963c836dcafa6db25d684f2aa691dea9738895f9140793e0f925784909e39f8257f7e1c7d611e8bd6d6634e1a50333f4ddb1e
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 18, 2020
Summary: > Two new signals are added beforehand in the first commit so that the connections in WalletFrame are all from the wallet view. This is a backport of Core [[bitcoin/bitcoin#17937 | PR17937]] [1/2] bitcoin/bitcoin@ac3d107 Test Plan: `ninja && src/qt/bitcoin-qt` Send a transaction, check that the transaction history page is automatically selected Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8698
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 19, 2020
Summary: > Essentially moves the code in WalletView::setBitcoinGUI to the only caller. Remove the circular dependency "qt/bitcoingui -> qt/walletview -> qt/bitcoingui" This is a backport of Core [[bitcoin/bitcoin#17937 | PR17937]] [2/2] bitcoin/bitcoin@cb8a86d Depends on D8698 Test Plan: `ninja && src/qt/bitcoin-qt` Test some of the connections Run `test/lint/lint-circular-dependencies.sh ` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8699
hebasto
added a commit
to bitcoin-core/gui
that referenced
this pull request
Jun 5, 2021
62cb8d9 qt: Drop BitcoinGUI* WalletFrame data member (Hennadii Stepanov) f73e5c9 qt: Move CreateWalletActivity connection from WalletFrame to BitcoinGUI (Hennadii Stepanov) 20e2e24 qt: Move WalletView connections from WalletFrame to BitcoinGUI (Hennadii Stepanov) Pull request description: This PR: - implements an idea from bitcoin/bitcoin#17937 (comment) - simplifies `WalletFrame` class interface - as a side effect, removes `bitcoingui` -> `walletframe` -> `bitcoingui` circular dependency - is an alternative to bitcoin/bitcoin#17500 ACKs for top commit: promag: Tested ACK 62cb8d9 on macos 11.2.3 with depends build. jarolrod: ACK 62cb8d9 Tree-SHA512: 633b526a8499ba9ab4b16928daf4de4f6d610284bb9fa51891cad35300a03bde740df3466a71b46e87a62121330fcc9e606eac7666ea5e45fa6d5785b60dcbbd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially moves the code in
WalletView::setBitcoinGUIto the only caller. Two new signals are added beforehand in the first commit so that the connections inWalletFrameare all from the wallet view.