gui: hide HD & encryption icons when no wallet loaded #17935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahiheb
reviewed
Jan 15, 2020
|
ACK 486f510 |
|
ACK 486f510 |
|
ACK 486f510 |
fanquake
added a commit
that referenced
this pull request
Jan 16, 2020
486f510 gui: hide HD & encryption icons when no wallet loaded (Harris) Pull request description: This PR takes care of removing (hiding) the HD wallet and encryption icons when no wallet is loaded. Fixes #17927 ACKs for top commit: Sjors: ACK 486f510 theStack: ACK 486f510 fanquake: ACK 486f510 - tested that this fixes #17927. Thanks for following up so quick. emilengler: ACK 486f510 Tree-SHA512: 6e3e5305a9eefe1692614097c05393aa0dffd561c89cefb40d501e70a8102eafcadfbc1c86a35c0b256b0f94f41598545d7a043954d6b9669c169d31d95aaf24
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Jan 21, 2020
luke-jr
reviewed
Jan 26, 2020
| @@ -659,6 +659,8 @@ void BitcoinGUI::removeWallet(WalletModel* walletModel) | |||
| rpcConsole->removeWallet(walletModel); | |||
| walletFrame->removeWallet(walletModel); | |||
| updateWindowTitle(); | |||
| labelWalletHDStatusIcon->hide(); | |||
| labelWalletEncryptionIcon->hide(); | |||
There was a problem hiding this comment.
This seems obviously broken... See PR #18007
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 23, 2020
Summary: The HD and encrypt status bar icons were not hidden after closing all wallets in bitcoin-qt. This is a Backport of Bitcoin Core [[bitcoin/bitcoin#17935 | PR17935]] and [[bitcoin/bitcoin#18007 | PR18007]] The second PR is a fix for a bug introduced by the first. Test Plan: Reproduce the issue before applying the commits: close all wallets in bitcoin-qt and check that status icons remain visible. Build, install, create 2 encrypted wallets, check that the icons now disappear when all wallets are closed, but remains visible after closing a wallet if a second wallet is still open. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D7540
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of removing (hiding) the HD wallet and encryption icons when no wallet is loaded.
Fixes #17927