scripted-diff: Replace CCriticalSection with RecursiveMutex #17891
Conversation
|
Concept ACK: explicit is better than implicit :) |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
ACK dc0e8b6 -- scripted diff looks correct |
|
ACK dc0e8b6 |
|
ACK dc0e8b6 |
|
Ugh. Messed up my merge order here, should have done this before #17906. @MarcoFalke can you please rebase. |
-BEGIN VERIFY SCRIPT- # Delete outdated alias for RecursiveMutex sed -i -e '/CCriticalSection/d' ./src/sync.h # Replace use of outdated alias with RecursiveMutex sed -i -e 's/CCriticalSection/RecursiveMutex/g' $(git grep -l CCriticalSection) -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-
|
Rebased and added another scripted diff to also bump the copyright headers of modified files in one go |
|
ACK e09c701 -- scripted diff looks correct |
|
ACK e09c701 |
|
ACK e09c701 diff and scripts look correct nit: ideally copyrights commit would be separate because unrelated, but all diffs are comments and it's scripted so nbd. Speaking of, could the copyright script be run automatically / periodically? I understand not wanting to run it via CI, but I would prefer either automatically/periodically or every time via CI over manually/sporadically. |
…utex e09c701 scripted-diff: Bump copyright of files changed in 2020 (MarcoFalke) 6cbe620 scripted-diff: Replace CCriticalSection with RecursiveMutex (MarcoFalke) Pull request description: `RecursiveMutex` better clarifies that the mutex is recursive, see also the standard library naming: https://en.cppreference.com/w/cpp/thread/recursive_mutex For that reason, and to avoid different people asking me the same question repeatedly (e.g. #15932 (review) ), remove the outdated alias `CCriticalSection` with a scripted-diff ACKs for top commit: Empact: ACK e09c701 diff and scripts look correct promag: ACK e09c701 practicalswift: ACK e09c701 -- scripted diff looks correct Tree-SHA512: 4bd7b5de1befdcf91dc8f43c127a1fee49679e06895a43216f160344a395c8e426dc68d529fbd2d5e1c215625a5a392dc415b1bce4127316aae7ecf98030c855
Summary: -BEGIN VERIFY SCRIPT- # Delete outdated alias for RecursiveMutex sed -i -e '/CCriticalSection/d' ./src/sync.h # Replace use of outdated alias with RecursiveMutex sed -i -e 's/CCriticalSection/RecursiveMutex/g' $(git grep -l CCriticalSection) -END VERIFY SCRIPT- This is a backport of Core [[bitcoin/bitcoin#17891 | PR17891]] Test Plan: ninja all check-all Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5825
Summary: -BEGIN VERIFY SCRIPT- # Delete outdated alias for RecursiveMutex sed -i -e '/CCriticalSection/d' ./src/sync.h # Replace use of outdated alias with RecursiveMutex sed -i -e 's/CCriticalSection/RecursiveMutex/g' $(git grep -l CCriticalSection) -END VERIFY SCRIPT- This is a backport of Core [[bitcoin/bitcoin#17891 | PR17891]] Test Plan: ninja all check-all Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5825
RecursiveMutexbetter clarifies that the mutex is recursive, see also the standard library naming: https://en.cppreference.com/w/cpp/thread/recursive_mutexFor that reason, and to avoid different people asking me the same question repeatedly (e.g. #15932 (review) ), remove the outdated alias
CCriticalSectionwith a scripted-diff